Skip to content

Remove unused DifferentiationInterface dependency #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewning merged 2 commits into from
Feb 13, 2026
Merged

Remove unused DifferentiationInterface dependency #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f11c6
Remove unused dependency
mx-p9a Feb 11, 2026
e017867
Fix NLsolve SubArray/Vector type mismatch with DI 0.7
mx-p9a Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ version = "1.1.0"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Expand All @@ -18,7 +17,6 @@ PyCallExt = "PythonCall"

[compat]
ChainRulesCore = "1.15"
DifferentiationInterface = "0.6"
ForwardDiff = "0.10.30, 1"
PythonCall = "0.9.28"
ReverseDiff = "1.14"
Expand Down
2 changes: 1 addition & 1 deletion docs/src/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ To solve these sets of residuals, we use the default trust-region method in NLso
```@example implicit
function onestep!(y, yprev, t, tprev, xd, xci, p)
f!(r, yt) = residual!(r, yt, yprev, t, tprev, xd, xci, p)
sol = nlsolve(f!, yprev, autodiff=:forward, ftol=1e-12)
sol = nlsolve(f!, Vector(yprev), autodiff=:forward, ftol=1e-12)
y .= sol.zero
return nothing
end
Expand Down
6 changes: 3 additions & 3 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ end

function onestep(yprev, t, tprev, xd, xci, p)
f(yt) = residual(yt, yprev, t, tprev, xd, xci, p)
sol = nlsolve(f, yprev, autodiff=:forward, ftol=1e-12)
sol = nlsolve(f, Vector(yprev), autodiff=:forward, ftol=1e-12)
return sol.zero
end

Expand Down Expand Up @@ -777,7 +777,7 @@ end

function onestep!(y, yprev, t, tprev, xd, xci, p)
f!(r, yt) = residual!(r, yt, yprev, t, tprev, xd, xci, p)
sol = nlsolve(f!, yprev, autodiff=:forward, ftol=1e-12)
sol = nlsolve(f!, Vector(yprev), autodiff=:forward, ftol=1e-12)
y .= sol.zero
return nothing
end
Expand Down Expand Up @@ -1115,4 +1115,4 @@ end
vjp(xbar, x, fbar)
@test all(isapprox.(xbar, J' * fbar, rtol=1e-15))

end
end