Skip to content

Fix insufficient commentUrlParamsRegex#35

Open
GiovanH wants to merge 1 commit intoc-hive:masterfrom
GiovanH:patch-1
Open

Fix insufficient commentUrlParamsRegex#35
GiovanH wants to merge 1 commit intoc-hive:masterfrom
GiovanH:patch-1

Conversation

@GiovanH
Copy link
Copy Markdown

@GiovanH GiovanH commented Aug 31, 2022

Fixes #34

@thisismydesign
Copy link
Copy Markdown
Member

Thanks for the fix! Could you enable the CI to run on your fork? Then if it's green I can merge it.

@GiovanH
Copy link
Copy Markdown
Author

GiovanH commented Aug 31, 2022

I've attempted to do so here https://github.com/GiovanH/actions/runs/8106103842?check_suite_focus=true but I'm not super familiar with github actions so it doesn't look like the new code has actually taken effect yet

@thisismydesign
Copy link
Copy Markdown
Member

On your fork repo, you need to enable github actions in the settings: https://github.com/GiovanH/fresh-bot

@GiovanH GiovanH force-pushed the patch-1 branch 3 times, most recently from c292740 to 42e4abc Compare August 31, 2022 07:17
@RichardFevrier
Copy link
Copy Markdown

👀

@GiovanH
Copy link
Copy Markdown
Author

GiovanH commented Jun 27, 2025

Actions were enabled as requested. I'm not sure what else to do here but if there's an action I can take I'm happy to.
image

@thisismydesign
Copy link
Copy Markdown
Member

I'll double-check why the CI wasn't running

Copy link
Copy Markdown
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove console.debug and pull latets master to run the ci

}

const commentParams = commentUrlParamsRegex.exec(subjectUrl);
console.debug(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove theconsole.debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: TypeError: Cannot read property 'groups' of null

3 participants