Conversation
- Fix clippy error - Add rust fmt rules
- Introduced .cargo/audit.toml to manage advisory ignores. - Updated GitHub Actions workflows to use actions/checkout@v4 and added steps to install Rust toolchain and cargo audit. - Modified audit and general workflows to run cargo audit and cargo fmt with the new configuration.
- Added concurrency configuration to audit, general, and release workflows to prevent overlapping runs. - Updated the trigger conditions for the general workflow to specify the master branch for push events.
- Added lifetime annotations to builder methods in the Mpesa client to improve type safety and prevent potential borrowing issues.
- Refactored the coverage job in the general workflow to use cargo-llvm-cov for generating code coverage reports. - Updated steps to install Rust and upload coverage results to Codecov, enhancing the CI process.
- Removed the CODECOV_TOKEN from the general workflow configuration to enhance security and prevent exposure of sensitive information.
Collaborator
Author
|
@c12i do you want to try codecov for using the coverage code better and display in the PR otherwise we really don't know what the coverage generates |
c12i
approved these changes
Aug 13, 2025
Owner
c12i
left a comment
c12i
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Approved with some suggestions on the security advisories.
@c12i do you want to try codecov for using the coverage code better and display in the PR otherwise we really don't know what the coverage generates
Definitely open to doing that, codecov already integrates smoothly with cargo-tarpaulin.
Collaborator
Author
|
@c12i I did change from taurpaulin to cargo llvm as it is more accurate from my readings and usage. |
Collaborator
Author
|
@c12i you can go ahead and create an account for it (free for public repos) and add the secret to the action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix clippy error
Add rust fmt rules
Added opinionated rust formatting rules.
Change to cargo llvm for coverage since it is more accurate and easier to use compared to taurpaulin