Update bill manager to latest api docs and use derive builder.#92
Draft
crispinkoech wants to merge 8 commits intoc12i:masterfrom
Draft
Update bill manager to latest api docs and use derive builder.#92crispinkoech wants to merge 8 commits intoc12i:masterfrom
crispinkoech wants to merge 8 commits intoc12i:masterfrom
Conversation
Owner
|
Hey @crispinkoech should I review while still in draft? |
Collaborator
Author
|
Naah, not yet. Will mark it as ready (and/or ping you) once it's good for
review.
…On Wed, 29 Nov 2023 at 17:39, Collins Muriuki ***@***.***> wrote:
Hey @crispinkoech <https://github.com/crispinkoech> should I review while
still in draft?
—
Reply to this email directly, view it on GitHub
<#92 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGIV6HTTX26DE2RLDCIK6PLYG5CLLAVCNFSM6AAAAAA74NPIKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGAZDEOBQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
Author
|
Oooft, this MR is too out of sync with the current master commit; @itsyaasir @c12i I suggest I close this and start some new work off of master? Also, when was the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87 and #91; still work in progress.