-
-
Notifications
You must be signed in to change notification settings - Fork 295
Add SipHash Family of Keyed PRFs #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerno
reviewed
Jul 10, 2025
lerno
reviewed
Jul 11, 2025
lerno
reviewed
Jul 11, 2025
lerno
reviewed
Jul 11, 2025
lerno
reviewed
Jul 11, 2025
lerno
reviewed
Jul 11, 2025
lerno
reviewed
Jul 11, 2025
lerno
reviewed
Jul 11, 2025
I posted some suggested improvements above. |
…undancies, add to release notes
I incorporated your feedback, and then some. I tend to put a lot of idiosyncrasies around explicit casts and parentheses in my code because I'm paranoid of C's UB and other spooky behaviors, so it'll take a bit for me to be a little more lax with the help of C3. Thank you for your time reviewing this. |
Updated the test to use this: char[64] plaintext = math::iota(char[64]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the SipHash family of pseudorandom functions, complete with accompanying tests.
Predefined modules include:
siphash24
- Performant - 64-bit hash from 2 rounds-per-block and 4 finalization rounds.siphash24_128
- Same as above but for 128-bit outputs.siphash48
- Hardened - 64-bit hash from 4 rounds-per-block and 8 finalization rounds.siphash48_128
- Same as above but for 128-bit outputs.Out-of-the-box usage:
Other non-standard variations of SipHash can be used with an
alias
declaration like so: