Feat/Add PriorityClassName To Helm Chart #362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-esp
requested review from
JTaeuber,
jon4skl and
jonathan-mayer
as code owners
samuel-esp
added
the
missing feature
JTaeuber
requested changes
Jan 26, 2026
| The default value for `priorityClassName` is: | ||
|
|
||
| ```yaml | ||
| priorityClass: |
Member
There was a problem hiding this comment.
Suggested change
| priorityClass: | |
| priorityClassName: "" |
| ```yaml | ||
| webhookController: | ||
| replicaCount: 1 | ||
| priorityClassName: "" |
Member
There was a problem hiding this comment.
This was changed by accident i suppose
|
|
||
| ```yaml | ||
| webhookController: | ||
| priorityClass: "" |
Member
There was a problem hiding this comment.
Suggested change
| priorityClass: "" | |
| priorityClassName: "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #361. Aligning the chart with PyKubeDownscaler chart
Changes
priorityClassNamefield for mainDeplyomentpriorityClassNamefield for WebhookDeplyoment@jonathan-mayer, @JTaeuber if you prefer, we could also refactor this to a value a single shared value for both Deployments, tell me your preference about this
Tests Done