Skip to content

Conversation

@samuel-esp
Copy link
Collaborator

Motivation

As stated in #342 this PR adds the option of settings custom values for QPS and Burst in the Kubernetes Client used by KubeDownscaler

Changes

  • Exposing QPS and Burst as argument for both the main deployment and the webhook
  • Added info in the documentations

Tests Done

  • Unit Tests
  • Live Tests

@samuel-esp samuel-esp self-assigned this Jan 25, 2026
@samuel-esp samuel-esp added the missing feature A feature still missing from the GoKubeDownscaler, compared to the py-kube-downscaler label Jan 25, 2026
@samuel-esp samuel-esp linked an issue Jan 25, 2026 that may be closed by this pull request
2 tasks
@samuel-esp samuel-esp requested a review from JTaeuber January 26, 2026 19:39
@samuel-esp
Copy link
Collaborator Author

@JTaeuber I added a commit to validate qps and burst values:

  • QPS: can be positive or negative, cannot be 0 (if user put 0, it will default to 5, as the library says so it's better to guard rail this unwanted case in my opinion). Negative is allowed to disable rate limiting
  • Burst: can only be greater than 0 (if user put 0, it will default to 10, so I reasoned like in the previous point). Negative can generate non-deterministic effects, so it is better to avoid it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing feature A feature still missing from the GoKubeDownscaler, compared to the py-kube-downscaler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make QPS, Burst and max-retries-on-throttling customizable

2 participants