refactor: modernize FPS architecture to V2#66
Merged
Conversation
Replaced legacy FUNCTION_PARAMETER_STRUCT and FUNCTION_PARAMETER with FPS and FPS_PARAM typedefs across the codebase. Replaced function_parameter_struct_connect/disconnect with fps_connect/disconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Cacao plugin ecosystem to align with the modernized MILK V2 framework architecture by adopting the new
FPStypedef and connection APIs.Changes
AOloopControl/computeCalibFUNCTION_PARAMETER_STRUCTwithFPSandFUNCTION_PARAMETERwithFPS_PARAMacross all compute loops and modules.function_parameter_struct_connect/disconnectcalls with the streamlinedfps_connectandfps_disconnectmacros/functions.Verification
/compile-testexecuted from themilkroot directory successfully rebuilds Cacao plugins)Prompt Summary
Following the modernization of the upstream MILK framework, the user requested to propagate the legacy FPS syntax cleanup (transitioning to
FPSandFPS_PARAMtypes) across the ecosystem, including the Cacao plugin repository.AI Authorship