refactor: decouple 3 cacao compute files from CLIcore.h

[oguyon]

Summary

Adds #ifdef MILK_NO_CLI dual-mode include guards to 3 pure compute files and replaces all data.core.image[] / data.core.NB_MAX_IMAGE accesses with the portable dcimg[] / dcnimg macros. This enables these files to compile cleanly in standalone (MILK_NO_CLI) builds without pulling in CLIcore.

Changes

Files Modified (3)

• computeCalib/modes_spatial_extrapolate.c — 6 data. refs → dcimg/dcnimg; fixed brace style on resolveIMGID error checks
• AOloopControl_PredictiveControl/AOloopControl_PredictiveControl_mapPredictiveFilter.c — 6 data. refs → dcimg/dcnimg
• AOloopControl_PredictiveControl/AOloopControl_PredictiveControl_setPFsimpleAve.c — 5 data. refs → dcimg/dcnimg

Include Pattern

Since cacao files use COREMOD functions (create_2Dimage_ID, delete_image, image_ID), the #else (library) path retains CLIcore.h. The decoupling benefit is in the #ifdef MILK_NO_CLI standalone path:

#ifdef MILK_NO_CLI
#include "CLIcore_standalone.h"
#else
#include "CLIcore.h"
#endif

Not Changed (Deferred)

4 files with deep data. coupling (18–89 refs including signal handlers and processinfo) are deferred to a future refactoring phase.

Verification

• Build passes (make -j)
• Tests pass (ctest 38/38)

Prompt Summary

The user requested Phase 3.2 of the dependency decoupling roadmap: applying the _compute library pattern to cacao AO loop control modules.

AI Authorship

• Model: Antigravity
• User edits: None