-
Notifications
You must be signed in to change notification settings - Fork 2
[Fix] Clean up all explict DataLoader usage #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @haochengxia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on simplifying the data loading workflow by deprecating the explicit Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cleans up the explicit usage of DataLoader by allowing TraceReader to handle S3 URIs directly. The changes in the examples and documentation reflect this new, simpler workflow. My review focuses on ensuring the documentation is accurate and that a potential issue in the C++ exception handling is addressed.
I've found a couple of issues in the documentation that need fixing: a broken code example and an incorrectly numbered list. More importantly, I've identified a bug in src/exception.cpp where the exception translator for custom exceptions is shadowed by a more generic one, which would prevent custom exceptions from being raised in Python. Please see my detailed comments for suggestions.
DataLoader