Fix Android indexAdd input validation - #788
Open
ZacharyZcR wants to merge 1 commit into
Open
Conversation
Signed-off-by: ZacharyZcR <zacharyzcr1984@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the React Native Android indexAdd input validation behavior with iOS to prevent unsafe JNI calls when the JS inputs are malformed (e.g., mismatched array lengths or ragged embeddings).
Changes:
- Reject
indexAddcalls whenids,documents,embeddings, and optionalmetadataslengths don’t match (before calling JNI). - Reject embeddings with inconsistent row dimensions to avoid out-of-bounds reads downstream.
- Wrap
readableNestedFloatArrays()so null embedding rows become promise rejections instead of uncaught exceptions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| val embArray = readableNestedFloatArrays(embeddings) | ||
| val embArray = try { | ||
| readableNestedFloatArrays(embeddings) | ||
| } catch (error: IllegalArgumentException) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #781.
Summary
ids,documents,embeddings, andmetadatasbefore JNIThe validation and error messages match the existing iOS behavior.
Validation
git diff --checknativeIndexAddThe repository does not include a standalone React Native Android Gradle test project, so no Android compilation was run.