feat: pretty errors with code snippets#5816
Open
christoph-dfinity wants to merge 20 commits intomasterfrom
Open
feat: pretty errors with code snippets#5816christoph-dfinity wants to merge 20 commits intomasterfrom
christoph-dfinity wants to merge 20 commits intomasterfrom
Conversation
Uses the grace library to pretty print snippets with markers and annotations
christoph-dfinity
force-pushed
the
christoph/grace-errors
branch
from
1cf40c2 to
8c02884
Compare
Contributor
christoph-dfinity
force-pushed
the
christoph/grace-errors
branch
from
17a915f to
a649fbb
Compare
Kamirus
reviewed
Feb 11, 2026
Contributor
Kamirus
left a comment
Kamirus
left a comment
There was a problem hiding this comment.
Use the --error-format flag?
Contributor
Author
|
Sorry it took me a while, but I finally got back to this. I think I made the changes we discussed last week. PTAL @Kamirus |
…christoph/grace-errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned off by default for now, can be turned on by setting the repurposed
--print-source-on-errorflag.Implementation
Uses the grace library to pretty print snippets with markers and annotations.
Extends our diagnostics type with spans and notes taking inspiration from https://rustc-dev-guide.rust-lang.org/diagnostics.html
I'd like to get this infrastructure in place first, and then incrementally make use of the spans to improve our existing errors. Once we're happy we can then flip the default for our human users.