Major refactoring #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Files, classes and methods names - No more inheritance from Faker - Moved Faker to fkUtils - Added a facade class Faker, which provides roughly the same API as the old Faker class - No more __get and __set magic, use of explicit methods call instead Added SPL autoloading
|
#seemlegit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi caius:
Thank you for sharing your work on php-faker.
May you be interested in some changes I've made in my own fork:
Deep refactoring, involving :
* Files, classes and methods names
* No more inheritance from Faker
* Moved Faker to fkUtils
* Added a facade class Faker, which provides roughly the same API as the old Faker class
* No more __get() and __set() magic, use of explicit methods call instead
Added SPL autoloading
Kind regards,
Stéphane