5.x Add first pass at migration table storage abstraction #951
+230
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the existing logic into another object. We could define an interface or extend this class for the new table storage. The Adapter layer can pick one table or the other based on config, and we can have both available at the same time for the upgrade process.
Member
Author
|
Any thoughts on this @dereuromark ? We'll likely need to add a |
Member
|
Looks a lot cleaner 👍 |
ADmad
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the existing logic into another object. We could define an interface or extend this class for the new table storage. The Adapter layer can pick one table or the other based on config, and we can have both available at the same time for the upgrade process.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Refs #822