Analyst logs in using their dot.ca.gov account #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Doc Ritezel <[email protected]>
Signed-off-by: Rae Bonfanti <[email protected]>
Signed-off-by: Rae Bonfanti <[email protected]>
ohrite
force-pushed
the
mov/36-analyst-logs-in
branch
from
3ff2a8c to
ef7fc4a
Compare
ohrite
force-pushed
the
mov/36-analyst-logs-in
branch
from
f6a28e5 to
ae886ed
Compare
|
The changes look good to me but I do not know much about Django. Since the demo looked good, I think we can move forward. |
shweta487
reviewed
Oct 14, 2025
src/cal_bc/settings.py
Outdated
| # See https://docs.djangoproject.com/en/5.2/howto/deployment/checklist/ | ||
|
|
||
| # SECURITY WARNING: keep the secret key used in production secret! | ||
| SECRET_KEY = "django-insecure-ehx7$j12*11z320lod=w9*kzgq*16)8s9+q_6)x%05#j#29uqa" |
There was a problem hiding this comment.
I assume this dev key is okay to be pushed?
There was a problem hiding this comment.
Definitely not once we deploy the app (we aren't yet). In any case, I'm going to go ahead and migrate this key to .env. Good catch.
@shweta487 ok sounds good. I addressed and corrected for the issue you pointed out. Would you be willing to approve this PR? Thanks! |
|
Thank you for making the change. We can merge this. |
shweta487
approved these changes
Oct 15, 2025
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds OIDC-based authentication via Caltrans' Microsoft Azure Entra ID.
Resolves [#36] and [#42]
Type of change
Acceptance notes
To accept this PR, you will need to start the application locally by following the setup instructions in
README.md. You will also need a set of credentials for the.envfile, as noted in those instructions, which @raebot or @ohrite can provide.Post-merge actions
No further action is required.