Skip to content

Conversation

@IlyaBausovAkvelon
Copy link
Contributor

No description provided.

@DmitriyKirakosyan
Copy link

@IlyaBausovAkvelon Carthage/Build shouldn't be tracked in the repository.

@@ -75,15 +75,6 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it removed?

@@ -241,8 +241,8 @@ - (id) init {


LPASLLogFormatter *ASLLogFormatter = [LPASLLogFormatter new];
[[LPASLLogger sharedInstance] setLogFormatter:ASLLogFormatter];
[LPLog addLogger:[LPASLLogger sharedInstance]];
//[[LPASLLogger sharedInstance] setLogFormatter:ASLLogFormatter];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commented?

#import <libkern/OSAtomic.h>

static NSString *const CalLogFormatterDateFormat = @"yyyy-MM-dd HH:mm:ss.SSS";
static NSString *const CalLogFormatterDateFormatterKey = @"sh.calaba.CalSSO-CalLogFormatter-NSDateFormatter";
@interface LPTTYLogFormatter () {
int32_t atomicLoggerCount;
atomic_int_fast32_t atomicLoggerCount;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share your thoughts on this decision? why need to change old type and why it should be changed to this type?


NSArray *results = [NSArray arrayWithArray:messages];

- (NSDictionary *) JSONResponseForMethod:(NSString *) method URI:(NSString *) path data:(NSDictionary *) data {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this code removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants