Skip to content

chore: unify parsing #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

chore: unify parsing #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/apple-llm/ios/AppleLLMImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public class AppleLLMImpl: NSObject {
for (toolName, toolDef) in toolsDict {
guard let description = toolDef["description"] as? String?,
let parameters = toolDef["parameters"] as? [String: Any]? else {
continue
throw AppleLLMError.invalidSchema("Invalid tool definition for \(toolName)")
}

let tool = try JSITool(
Expand Down Expand Up @@ -244,7 +244,7 @@ public class AppleLLMImpl: NSObject {
for message in transcriptMessages {
guard let role = message["role"] as? String,
let content = message["content"] as? String else {
continue
throw AppleLLMError.invalidMessage("Message must have role and content")
}

let segment = Transcript.Segment.text(
Expand Down Expand Up @@ -395,7 +395,7 @@ public class AppleLLMImpl: NSObject {

for (propertyName, propertySchema) in propertiesDict {
guard let propertySchemaDict = propertySchema as? [String: Any] else {
continue
throw AppleLLMError.invalidSchema("Property \(propertyName) schema must be an object")
}

let isOptional = !requiredFields.contains(propertyName)
Expand Down