Skip to content

Conversation

bacarybruno
Copy link

@bacarybruno bacarybruno commented Sep 8, 2025

Context: callstack/rock#552

This PR adds the initial version of the Rock Bitrise workflow.
It is largely based on the existing GitHub Actions workflow, which also served as the reference for the step.sh script.

At this stage, step.sh duplicates some of the logic defined in action.yml.
In future iterations, we can consider extracting the common functionality into a shared script or library so that both Bitrise and GitHub workflows can consume the same code and stay in sync.

Documentation will follow once we align on this PR.

@thymikee
Copy link
Contributor

thymikee commented Sep 9, 2025

Looks good! How can we test this? Do you have a sample repo you could share?

@bacarybruno
Copy link
Author

I tested it manually by creating a new rock project, but I can prepare a sample repo yes 👍

@bacarybruno
Copy link
Author

Hello again!

I tested using this workflow file: bitrise.yml.

Screenshot 2025-09-09 at 20 20 32

It works, but I had to create a dedicated repository to host the Bitrise workflow: bitrise-rock-remote-build-ios, since Bitrise requires the step.yml file to be at the repository root.

So now we have two possible approaches:
1️⃣ Move step.yml and step.sh to the root of the current repo.
2️⃣ Keep a dedicated repo just for the Bitrise workflow.

Which option do you think we should go with? Or do you see another possible solution?

@thymikee
Copy link
Contributor

If possible, I'd keep the code colocated. Especially if we could reuse some of these shell scripts

@thymikee
Copy link
Contributor

I've invited you to our internal repo for testing Rock's remote builds: https://github.com/callstack-internal/rock-remote-build-test/. I think we should make it public soon, and it could be our test bed for CI workflows we support

@bacarybruno
Copy link
Author

bacarybruno commented Sep 10, 2025

If possible, I'd keep the code colocated. Especially if we could reuse some of these shell scripts

Good point, I updated the PR to move the bitrise step to the repository root + tested the workflow on rock-remote-build-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants