-
Notifications
You must be signed in to change notification settings - Fork 3
feat: create bitrise step #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Looks good! How can we test this? Do you have a sample repo you could share? |
I tested it manually by creating a new rock project, but I can prepare a sample repo yes 👍 |
Hello again! I tested using this workflow file: bitrise.yml. ![]() It works, but I had to create a dedicated repository to host the Bitrise workflow: bitrise-rock-remote-build-ios, since Bitrise requires the So now we have two possible approaches: Which option do you think we should go with? Or do you see another possible solution? |
If possible, I'd keep the code colocated. Especially if we could reuse some of these shell scripts |
I've invited you to our internal repo for testing Rock's remote builds: https://github.com/callstack-internal/rock-remote-build-test/. I think we should make it public soon, and it could be our test bed for CI workflows we support |
Good point, I updated the PR to move the bitrise step to the repository root + tested the workflow on rock-remote-build-test. |
Context: callstack/rock#552
This PR adds the initial version of the Rock Bitrise workflow.
It is largely based on the existing GitHub Actions workflow, which also served as the reference for the
step.sh
script.At this stage,
step.sh
duplicates some of the logic defined inaction.yml
.In future iterations, we can consider extracting the common functionality into a shared script or library so that both Bitrise and GitHub workflows can consume the same code and stay in sync.
Documentation will follow once we align on this PR.