Implementation of napi_fatal_error and napi_get*_version functions

.changeset/kind-forks-talk.md

@@ -0,0 +1,5 @@
+---
+"react-native-node-api": patch
+---
+
+Added implementation of napi_fatal_error, napi_get_node_version and napi_get_version. Improved the Logger functionalities

packages/host/cpp/Logger.cpp

@@ -9,27 +9,77 @@
 #include <TargetConditionals.h>
 #endif
 
-namespace callstack::nodeapihost {
-void log_debug(const char *format, ...) {
-  // TODO: Disable logging in release builds
+namespace {
+constexpr auto LineFormat = "[%s] [NodeApiHost] ";
 
-  va_list args;
-  va_start(args, format);
+enum class LogLevel { Debug, Warning, Error };
+
+constexpr std::string_view levelToString(LogLevel level) {
+  switch (level) {
+    case LogLevel::Debug:
+      return "DEBUG";
+    case LogLevel::Warning:
+      return "WARNING";
+    case LogLevel::Error:
+      return "ERROR";
+    default:
+      return "UNKNOWN";
+  }
+}
 
 #if defined(__ANDROID__)
-  __android_log_vprint(ANDROID_LOG_DEBUG, LOG_TAG, format, args);
+constexpr int androidLogLevel(LogLevel level) {
+  switch (level) {
+    case LogLevel::Debug:
+      return ANDROID_LOG_DEBUG;
+    case LogLevel::Warning:
+      return ANDROID_LOG_WARN;
+    case LogLevel::Error:
+      return ANDROID_LOG_ERROR;
+    default:
+      return ANDROID_LOG_UNKNOWN;
+  }
+}
+#endif
+
+void log_message_internal(LogLevel level, const char* format, va_list args) {
+#if defined(__ANDROID__)
+  __android_log_vprint(androidLogLevel(level), LOG_TAG, format, args);
 #elif defined(__APPLE__)
   // iOS or macOS
-  fprintf(stderr, "[NodeApiHost] ");
+  const auto level_str = levelToString(level);
+  fprintf(stderr, LineFormat, level_str.data());
   vfprintf(stderr, format, args);
   fprintf(stderr, "\n");
 #else
   // Fallback for other platforms
-  fprintf(stdout, "[NodeApiHost] ");
+  const auto level_str = levelToString(level);
+  fprintf(stdout, LineFormat, level_str.data());
   vfprintf(stdout, format, args);
   fprintf(stdout, "\n");
 #endif
+}
+}  // anonymous namespace
+
+namespace callstack::nodeapihost {
 
+void log_debug(const char* format, ...) {
+  // TODO: Disable logging in release builds
+  va_list args;
+  va_start(args, format);
+  log_message_internal(LogLevel::Debug, format, args);
+  va_end(args);
+}
+void log_warning(const char* format, ...) {
+  va_list args;
+  va_start(args, format);
+  log_message_internal(LogLevel::Warning, format, args);
+  va_end(args);
+}
+void log_error(const char* format, ...) {
+  va_list args;
+  va_start(args, format);
+  log_message_internal(LogLevel::Error, format, args);
   va_end(args);
 }
-} // namespace callstack::nodeapihost
+}  // namespace callstack::nodeapihost

packages/host/cpp/Logger.hpp

@@ -3,5 +3,7 @@
 #include <string>
 
 namespace callstack::nodeapihost {
-void log_debug(const char *format, ...);
-}
+void log_debug(const char* format, ...);
+void log_warning(const char* format, ...);
+void log_error(const char* format, ...);
+}  // namespace callstack::nodeapihost

packages/host/cpp/RuntimeNodeApi.cpp

@@ -1,5 +1,7 @@
 #include "RuntimeNodeApi.hpp"
 #include <string>
+#include "Logger.hpp"
+#include "Versions.hpp"
 
 auto ArrayType = napi_uint8_array;
 
@@ -121,4 +123,40 @@ napi_status napi_create_external_buffer(napi_env env,
   return napi_create_typedarray(env, ArrayType, length, buffer, 0, result);
 }
 
+void napi_fatal_error(const char* location,
+    size_t location_len,
+    const char* message,
+    size_t message_len) {
+  log_error("Fatal error in Node-API: %.*s: %.*s",
+      static_cast<int>(location_len),
+      location,
+      static_cast<int>(message_len),
+      message);
+  abort();
+}
+
+napi_status napi_get_node_version(
+    node_api_basic_env env, const napi_node_version** result) {
+  if (!result) {
+    return napi_invalid_arg;
+  }
+
+  static napi_node_version version = {
+      .major = NODE_MAJOR_VERSION,
+      .minor = NODE_MINOR_VERSION,
+      .patch = NODE_PATCH_VERSION,
+  };
+  *result = &version;
+  return napi_ok;
+}
+
+napi_status napi_get_version(node_api_basic_env env, uint32_t* result) {
+  if (!result) {
+    return napi_invalid_arg;
+  }
+
+  *result = NAPI_VERSION;
+  return napi_ok;
+}
+
 }  // namespace callstack::nodeapihost

packages/host/cpp/RuntimeNodeApi.hpp

@@ -23,4 +23,14 @@ napi_status napi_create_external_buffer(napi_env env,
     node_api_basic_finalize basic_finalize_cb,
     void* finalize_hint,
     napi_value* result);
+
+void __attribute__((noreturn)) napi_fatal_error(const char* location,
+    size_t location_len,
+    const char* message,
+    size_t message_len);
+
+napi_status napi_get_node_version(
+    node_api_basic_env env, const napi_node_version** result);
+
+napi_status napi_get_version(node_api_basic_env env, uint32_t* result);
 }  // namespace callstack::nodeapihost

packages/host/cpp/Versions.hpp

@@ -0,0 +1,7 @@
+#pragma once
+
+#define NODE_MAJOR_VERSION 8
+#define NODE_MINOR_VERSION 6
+#define NODE_PATCH_VERSION 0
+
+#define NAPI_VERSION 1

packages/host/scripts/generate-weak-node-api-injector.ts

@@ -17,6 +17,9 @@ const IMPLEMENTED_RUNTIME_FUNCTIONS = [
   "napi_queue_async_work",
   "napi_delete_async_work",
   "napi_cancel_async_work",
+  "napi_fatal_error",
+  "napi_get_node_version",
+  "napi_get_version",
 ];
 
 /**