chore: migrated to package manager to pnpm #204

dougg0k · 2025-07-25T02:43:34Z

Before I had trouble using npm i in the root, ferric-cli were not running, it wasnt finding the js.

Even if it were recognized in the package-lock as workspace installed.

It only worked after I did a pnpm i straight in the ferric folder, then I was able to run the command standalone. That's the experience I had.

This led to this PR. Which in fact work now just after a pnpm install in the root folder.

pnpm are faster, in my experience, there is no reason to not migrate to it, even more if from npm.

https://pnpm.io/pnpm-vs-npm

https://refine.dev/blog/pnpm-vs-npm-and-yarn/ - Faster CI installs and more

changeset-bot · 2025-07-25T02:43:39Z

🦋 Changeset detected

Latest commit: 51df6e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@react-native-node-api/ferric-example	Patch
cmake-rn	Patch
ferric-cli	Patch
@react-native-node-api/test-app	Patch
react-native-node-api	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dougg0k · 2025-07-25T02:48:08Z

This is even showing errors that does not show with npm.

❯ pnpm bootstrap                                                                                                                                                                                                                                                                                                                                                                     23:42:00

> @react-native-node-api/root@ bootstrap /react-native-node-api
> pnpm build && pnpm bootstrap --workspaces --if-present


> @react-native-node-api/root@ build /react-native-node-api
> tsc --build

packages/host/src/node/babel-plugin/plugin.ts:43:5 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(replacementPath: Node | NodePath<Node>): [NodePath<Node>]', gave the following error.
    Argument of type 'CallExpression' is not assignable to parameter of type 'Node | NodePath<Node>'.
      Type 'import("/react-native-node-api/node_modules/.pnpm/@[email protected]/node_modules/@babel/types/lib/index").CallExpression' is not assignable to type 'babel.types.CallExpression'.
        Types of property 'callee' are incompatible.
          Type 'Expression | V8IntrinsicIdentifier' is not assignable to type 'V8IntrinsicIdentifier | Expression'.
            Type 'ArrayExpression' is not assignable to type 'V8IntrinsicIdentifier | Expression'.
              Type 'import("/react-native-node-api/node_modules/.pnpm/@[email protected]/node_modules/@babel/types/lib/index").ArrayExpression' is not assignable to type 'babel.types.ArrayExpression'.
                Types of property 'elements' are incompatible.
                  Type '(Expression | SpreadElement | null)[]' is not assignable to type '(SpreadElement | Expression | null)[]'.
                    Type 'Expression | SpreadElement | null' is not assignable to type 'SpreadElement | Expression | null'.
                      Type 'ArrayExpression' is not assignable to type 'SpreadElement | Expression | null'.
  Overload 2 of 2, '(replacementPath: NodePath<Node>): [NodePath<Node>]', gave the following error.
    Argument of type 'CallExpression' is not assignable to parameter of type 'NodePath<Node>'.
      Type 'CallExpression' is missing the following properties from type 'NodePath<Node>': parent, hub, data, context, and 721 more.

 43     t.callExpression(
        ~~~~~~~~~~~~~~~~~
 44       t.memberExpression(
    ~~~~~~~~~~~~~~~~~~~~~~~~~
...
 50       [t.stringLiteral(requireCallArgument)]
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 51     )
    ~~~~~



Found 1 error.

❯ npm run bootstrap

> bootstrap
> npm run build && npm run bootstrap --workspaces --if-present


> build
> tsc --build


> [email protected] bootstrap
> npm run copy-node-api-headers && npm run generate-weak-node-api-injector && npm run generate-weak-node-api && npm run build-weak-node-api

shirakaba · 2025-07-25T03:14:36Z

Before I had trouble using npm i, even if it were recognized in the package-lock as some package as installed, when running commands in a folder, it would not work, unless I specifically ran install (non-npm).

I didn't experience that when I cloned and installed the repo. Would it help if we just regenerated the package-lock.json?

What version of npm are you using? I'm using 10.9.2.

dougg0k · 2025-07-25T03:15:31Z

Already did.

Same version.

With pnpm another issue appeared through the CI, and were not showing before with npm.

Clearly pnpm are working properly where npm was not.

> pnpm --recursive --if-present build

Scope: 7 of 8 workspace projects
packages/gyp-to-cmake build$ tsc
packages/host build$ tsc --build
packages/node-addon-examples build$ tsx scripts/build-examples.mts
packages/node-addon-examples build: node:fs:1583
packages/node-addon-examples build:   const result = binding.readdir(
packages/node-addon-examples build:                          ^
packages/node-addon-examples build: Error: ENOENT: no such file or directory, scandir '/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/examples'
packages/node-addon-examples build:     at readdirSync (node:fs:1583:26)
packages/node-addon-examples build:     at findCMakeProjectsRecursively (/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/cmake-projects.mts:10:17)
packages/node-addon-examples build:     at Array.flatMap (<anonymous>)
packages/node-addon-examples build:     at findCMakeProjects (/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/cmake-projects.mts:25:15)
packages/node-addon-examples build:     at <anonymous> (/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/build-examples.mts:5:28)
packages/node-addon-examples build:     at ModuleJob.run (node:internal/modules/esm/module_job:329:25)
packages/node-addon-examples build:     at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:644:26)
packages/node-addon-examples build:     at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5) {
packages/node-addon-examples build:   errno: -2,
packages/node-addon-examples build:   code: 'ENOENT',
packages/node-addon-examples build:   syscall: 'scandir',
packages/node-addon-examples build:   path: '/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/examples'
packages/node-addon-examples build: }
packages/node-addon-examples build: Node.js v22.17.1
packages/node-addon-examples build: Failed
/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @react-native-node-api/node-addon-examples@ build: `tsx scripts/build-examples.mts`
Exit status 1

…replace-package-manager

dougg0k · 2025-07-25T13:55:05Z

And more.

ackages/node-addon-examples test: node:internal/fs/promises:955
packages/node-addon-examples test:   const result = await PromisePrototypeThen(
packages/node-addon-examples test:                  ^
packages/node-addon-examples test: Error: ENOENT: no such file or directory, scandir '/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/examples/5-async-work/async_work_thread_safe_function/napi/build/Release/binding.android.node/armeabi-v7a'
packages/node-addon-examples test:     at async Object.readdir (node:internal/fs/promises:955:18)
packages/node-addon-examples test:     at async verifyAndroidPrebuild (/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/verify-prebuilds.mts:28:24)
packages/node-addon-examples test:     at async <anonymous> (/home/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/verify-prebuilds.mts:90:5) {

packages/node-addon-examples test: node:internal/fs/promises:955
packages/node-addon-examples test:   const result = await PromisePrototypeThen(
packages/node-addon-examples test:                  ^
packages/node-addon-examples test: Error: ENOENT: no such file or directory, scandir '/Users/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/examples/5-async-work/async_work_thread_safe_function/napi/build/Release/binding.apple.node/ios-arm64'
packages/node-addon-examples test:     at async Object.readdir (node:internal/fs/promises:955:18)
packages/node-addon-examples test:     at async verifyApplePrebuild (/Users/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/verify-prebuilds.mts:47:24)
packages/node-addon-examples test:     at async <anonymous> (/Users/runner/work/react-native-node-api/react-native-node-api/packages/node-addon-examples/scripts/verify-prebuilds.mts:95:5) {

packages/host/package.json

packages/node-addon-examples/scripts/cmake-projects.mts

packages/node-addon-examples/scripts/verify-prebuilds.mts

kraenhansen · 2025-07-25T20:49:38Z

I would like for you to create an issue for the NPM issue which prompted you to want to migrate to PNPM in the first place, I'm fairly certain we could fix that without migrating package manager.

Some of the issues you're seeing might come from:

the "build" scripts aren't designed to be ran in sequence across all workspaces, as some build native addon code while others build TS locally for that package. Right now, we use the "bootstrap" script as the script a package implements to prepare for development.
NPM runs scripts in order of entry in the workspaces array of the package.json, whereas PNPM runs them in topological order - and the scripts aren't necessarily designed for that.

dougg0k · 2025-07-25T21:16:08Z

https://pnpm.io/cli/recursive#--no-sort

Weird that you do not prefer better tooling.

As one can easily replace one for another, if ever needed.

I gave the reasons in the PR.

Not looking to resolve the issues in the current, but actual improve while resolving some that I mentioned.

pnpm are clearly more functional than npm.

kraenhansen · 2025-07-26T05:38:21Z

Weird that you do not prefer better tooling.

Not weird at all - we're the ones maintaining this package in the long run and choosing technology / tools aren't soly about choosing the seemingly superior solution in my experience. To be clear, I'm not saying that NPM is flawless nor that we won't make a switch to a different package manager and I'm not looking to get more into that conversation right now.

I gave the reasons in the PR.

I disagree, as I'm unable to reproduce the issue: You're not providing specific commands and outputs from running those and therefore I'm unable to get a strong signal, giving me a compelling reason to accept your suggested change.

…ager

dougg0k · 2025-09-22T20:48:35Z

@kraenhansen Given your last message, I answered but no response were given, should I assume that this PR is not wanted / needed?

kraenhansen · 2025-09-23T06:35:47Z

I assume that this PR is not wanted / needed?

Right. Without a clearly defined need, I don't see us merging this any time soon 👍

migrated to pnpm

184fc43

dougg0k added 2 commits July 25, 2025 00:04

temp type fix and fixed scripts

6b67400

disabled lint in line

ebeb2c5

dougg0k mentioned this pull request Jul 25, 2025

fix: cargo build release flag #203

Merged

dougg0k added 8 commits July 25, 2025 10:09

example possible error fix

4656a57

Merge branch 'main' of github.com:dougg0k/react-native-node-api into …

8e85d15

…replace-package-manager

added skiplibcheck

40e9221

added skiplibcheck in another proj

1a04847

removed skip lib from a project and added @types

5c61df5

changed ferric dep to actual version back

698c6f2

add changes

ee06e8a

added released changes

7768127

dougg0k added 4 commits July 25, 2025 10:56

added check

04df8c5

fixed check

c094863

added check to apple fn

a2f03dc

try without skiplib

af071fb

dougg0k mentioned this pull request Jul 25, 2025

feat: improve ferric build #205

Open

2 tasks

kraenhansen reviewed Jul 25, 2025

View reviewed changes

packages/host/package.json Show resolved Hide resolved

kraenhansen reviewed Jul 25, 2025

View reviewed changes

packages/node-addon-examples/scripts/cmake-projects.mts Outdated Show resolved Hide resolved

kraenhansen reviewed Jul 25, 2025

View reviewed changes

packages/node-addon-examples/scripts/verify-prebuilds.mts Outdated Show resolved Hide resolved

kraenhansen reviewed Jul 25, 2025

View reviewed changes

packages/node-addon-examples/scripts/verify-prebuilds.mts Outdated Show resolved Hide resolved

dougg0k mentioned this pull request Jul 26, 2025

Reduce native files size #196

Closed

dougg0k added 2 commits August 2, 2025 11:24

fixed lock and workspace dependency

a4e7b67

fixed formatting

44be588

kraenhansen added Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) labels Aug 2, 2025

dougg0k added 15 commits August 9, 2025 10:52

Merge remote-tracking branch 'upstream/main' into replace-package-man…

0f32d7b

…ager

updated pnpm lock

7def782

Merge remote-tracking branch 'upstream/main' into replace-package-man…

b26bc86

…ager

updated pnpm lock

10af188

fixed typos

64b7229

removed exists checks

2dabae2

fixed workspace package version

c3fa120

removed no-sort

a8c88d2

removed and updated more versions

338582b

some versions fixes

0155394

updated check ci

a17b508

attempt to fix build

d169fc4

added bootstrap command to package

330f017

add no sort to command

7347f21

Merge remote-tracking branch 'upstream/main' into replace-package-man…

e655d71

…ager

This comment was marked as outdated.

Sign in to view

fixed bad merge

94f6660

This comment was marked as outdated.

Sign in to view

fixed another json

9418c27

This comment was marked as outdated.

Sign in to view

regenerated pnpm and fixed workspace versions

2d82138

This comment was marked as outdated.

Sign in to view

changed some versions to workspace

97ed4eb

dougg0k closed this Sep 22, 2025

chore: migrated to package manager to pnpm #204

chore: migrated to package manager to pnpm #204

Uh oh!

Conversation

dougg0k commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dougg0k commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shirakaba commented Jul 25, 2025

Uh oh!

dougg0k commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougg0k commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kraenhansen commented Jul 25, 2025

Uh oh!

dougg0k commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kraenhansen commented Jul 26, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

dougg0k commented Sep 22, 2025

Uh oh!

kraenhansen commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dougg0k commented Jul 25, 2025 •

edited

Loading

changeset-bot bot commented Jul 25, 2025 •

edited

Loading

dougg0k commented Jul 25, 2025 •

edited

Loading

dougg0k commented Jul 25, 2025 •

edited

Loading

dougg0k commented Jul 25, 2025 •

edited

Loading

dougg0k commented Jul 25, 2025 •

edited

Loading