Skip to content

React Native 0.81.1 (0.79.6, 0.80.0, 0.80.1, 0.80.2 & 0.81.0) #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 13, 2025
Merged

React Native 0.81.1 (0.79.6, 0.80.0, 0.80.1, 0.80.2 & 0.81.0) #225

merged 9 commits into from
Sep 13, 2025

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Sep 1, 2025 •
edited
Loading

I've rebased and pushed tags of Node-API support for Hermes on the most recent Hermes tags:

Merging this PR will:

  • Update the peer dependency range of the host package to include the most recent React Native releases.
  • Update the test app to use 0.81.1 when running tests.
  • Nuke and rebuild the package lock (because NPM 😞)
  • Upgrade gradle wrapper properties (as this was introduced as an unstaged change when rebuilding)
  • Rename the ferric-example package in the test app - I have no clue why this passed on main 😬 since d367b6e merged (perhaps the package-lock.json acted as a cache somehow).
  • Remove the explicit linking of the host with the weak-node-api library to prevent the host from injecting the weak-node-api symbols into itself.

Note: While testing this locally, I had to clean the CocoaPods cache pod cache clean --all or the ios/Pods/hermes-engine wouldn't match the local patched version.

@kraenhansen kraenhansen self-assigned this Sep 1, 2025
@kraenhansen kraenhansen added CI Continuous integration Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) Host 🏡 Our `react-native-node-api-modules` package labels Sep 1, 2025
@kraenhansen kraenhansen force-pushed the kh/react-native-0.81.1 branch from b0acd08 to 5ece1e0 Compare September 2, 2025 17:14
@kraenhansen
Copy link
Collaborator Author

This is currently crashing on Android:

Build fingerprint: 'google/sdk_gphone64_arm64/emu64a:14/UE1A.230829.050/12077443:userdebug/dev-keys'
2025-09-02 20:08:03.354  5305-5305  DEBUG                   pid-5305                             A  Revision: '0'
2025-09-02 20:08:03.354  5305-5305  DEBUG                   pid-5305                             A  ABI: 'arm64'
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  Timestamp: 2025-09-02 20:08:03.062457661+0200
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  Process uptime: 48s
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  Cmdline: com.microsoft.reacttestapp
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  pid: 5049, tid: 5193, name: mqt_v_js  >>> com.microsoft.reacttestapp <<<
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  uid: 10193
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  pac_enabled_keys: 000000000000000f (PR_PAC_APIAKEY, PR_PAC_APIBKEY, PR_PAC_APDAKEY, PR_PAC_APDBKEY)
2025-09-02 20:08:03.355  5305-5305  DEBUG                   pid-5305                             A  signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x0000007400640ff8
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A  Cause: stack pointer is not in a rw map; likely due to stack overflow.
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x0  b4000074f6b19c50  x1  000000740073ff20  x2  000000773d1367c4  x3  0000000000000010
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x4  0000000000000000  x5  00000073e9984e58  x6  b400007666a83e00  x7  64656c646e61486e
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x8  0000007401889dbc  x9  e827a6ddf7556d11  x10 0000000000000000  x11 b4000075a6af9730
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x12 b4000074f6b19c50  x13 0000000000000001  x14 0000000000000001  x15 0000000000000000
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x16 000000740186bdc8  x17 0000007401889dbc  x18 00000073f17fe000  x19 b400007556abf708
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x20 b400007486b2ea78  x21 b4000074f6b19c50  x22 0000007400745000  x23 0000000000000000
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x24 0000007400745000  x25 b400007486b2ea89  x26 0000000000000001  x27 b400007556a8bc7d
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      x28 00000073e9984d78  x29 0000007400641000
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A      lr  0000007401889e18  sp  0000007400640ff0  pc  0000007401889dc8  pst 0000000080001000
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A  512 total frames
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A  backtrace:
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #00 pc 0000000000006dc8  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+12) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #01 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #02 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #03 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #04 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #05 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #06 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #07 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #08 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #09 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.356  5305-5305  DEBUG                   pid-5305                             A        #10 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #11 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #12 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #13 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #14 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #15 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #16 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #17 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #18 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #19 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)
2025-09-02 20:08:03.357  5305-5305  DEBUG                   pid-5305                             A        #20 pc 0000000000006e14  /data/app/~~CfrArdb9hVKa2565V9ZlAQ==/com.microsoft.reacttestapp-HsRCQfNLy6WUUkGtdcKZCg==/base.apk!libweak-node-api.so (offset 0x26c0000) (napi_create_object+88) (BuildId: e84f88415ae049676118f39a2d0418a6a1681bbf)

I suspect this might be related to some change in how Hermes symbols are exported, making the "weak node api" injector, inject it's own implementation into itself 🤦

@kraenhansen kraenhansen mentioned this pull request Sep 12, 2025
Closed
@kraenhansen kraenhansen force-pushed the kh/react-native-0.81.1 branch from 20c19fe to a490b57 Compare September 12, 2025 22:51
@kraenhansen kraenhansen merged commit a0212c8 into main Sep 13, 2025
16 of 18 checks passed
@kraenhansen kraenhansen deleted the kh/react-native-0.81.1 branch September 13, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matthargett matthargett matthargett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kraenhansen kraenhansen

Labels

Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) CI Continuous integration Host 🏡 Our `react-native-node-api-modules` package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kraenhansen @matthargett