Skip to content

Conversation

kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented May 14, 2025

(stacked on #49)

Merging this PR will:

  • Replace the napi.rs comment in the generated d.ts and our .js entrypoint:

A generated ferric_example.js

/* eslint-disable */

/**
 * This file was generated by
 * ╭─────────────────────────╮
 * │░█▀▀░█▀▀░█▀▄░█▀▄░▀█▀░█▀▀░│
 * │░█▀▀░█▀▀░█▀▄░█▀▄░░█░░█░░░│
 * │░▀░░░▀▀▀░▀░▀░▀░▀░▀▀▀░▀▀▀░│
 * ╰─────────────────────────╯
 * Powered by napi.rs
 */

module.exports = require('./ferric_example.node');

A generated ferric_example.d.ts

/* tslint:disable */
/* eslint-disable */

/**
 * This file was generated by
 * ╭─────────────────────────╮
 * │░█▀▀░█▀▀░█▀▄░█▀▄░▀█▀░█▀▀░│
 * │░█▀▀░█▀▀░█▀▄░█▀▄░░█░░█░░░│
 * │░▀░░░▀▀▀░▀░▀░▀░▀░▀▀▀░▀▀▀░│
 * ╰─────────────────────────╯
 * Powered by napi.rs
 */

export declare function sum(a: number, b: number): number

@kraenhansen kraenhansen self-assigned this May 14, 2025
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: a817394

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kraenhansen kraenhansen force-pushed the kh/apple-prebuilds-renamed branch from 51e41d9 to 1848720 Compare May 15, 2025 05:54
@kraenhansen kraenhansen changed the title Emit "Ferric" into generated files. Emit "Ferric" into generated files May 15, 2025
@kraenhansen kraenhansen force-pushed the kh/napi-rs-banners branch from 42854d6 to 954af4c Compare May 15, 2025 05:55
@kraenhansen kraenhansen requested a review from mani3xis May 15, 2025 05:55
@kraenhansen
Copy link
Collaborator Author

kraenhansen commented May 15, 2025

This needs a bit more work 🤣😭

Screenshot 2025-05-15 at 11 50 33

☝️ Turns out I just need to add a comment on the first exported Rust function / struct - I can live with that 👍

@kraenhansen kraenhansen force-pushed the kh/apple-prebuilds-renamed branch from 1848720 to 8c83d1c Compare May 17, 2025 21:31
@kraenhansen kraenhansen force-pushed the kh/napi-rs-banners branch 2 times, most recently from 3f8724e to 48b4496 Compare May 17, 2025 21:40
@kraenhansen kraenhansen changed the base branch from kh/apple-prebuilds-renamed to kh/weak-node-api-injection May 17, 2025 21:40
Base automatically changed from kh/weak-node-api-injection to main May 19, 2025 14:33
@kraenhansen kraenhansen force-pushed the kh/napi-rs-banners branch from 48b4496 to a817394 Compare May 19, 2025 14:36
@kraenhansen kraenhansen merged commit 7315fd5 into main May 21, 2025
3 checks passed
@kraenhansen kraenhansen deleted the kh/napi-rs-banners branch May 21, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants