Skip to content

Conversation

kraenhansen
Copy link
Collaborator

I'm not certain that this is what we actually want, so I'm putting this up as a draft, just in the interest of transparency and starting a conversation.
No need to review this in detail, just yet.

I write this as part of playing around with using the packages outside of the mono-repo.

Merging this PR will:

  • Clone hermes into the app's package root instead the host package's root.

If we merge this we'd have to instruct the user to add hermes to their gitignore.

@kraenhansen kraenhansen self-assigned this May 17, 2025
Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: d761a2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kraenhansen kraenhansen changed the base branch from main to kh/napi-rs-banners May 17, 2025 11:40
@kraenhansen kraenhansen changed the title Clone hermes into app directory Optionally clone hermes into app directory and fix patch of React Native's JSI May 17, 2025
@kraenhansen kraenhansen changed the title Optionally clone hermes into app directory and fix patch of React Native's JSI Minor fixes from using package outside of a mono-repo May 17, 2025
@kraenhansen kraenhansen changed the title Minor fixes from using package outside of a mono-repo Optionally clone Hermes into the App's directory May 17, 2025
@kraenhansen
Copy link
Collaborator Author

Made up my mind already 🙈 There's no real need for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant