Add transformation of "defines" to gyp-to-cmake
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matthargett
reviewed
Jun 3, 2025
|
|
||
| function escapePath(source: string) { | ||
| function escapeSpaces(source: string) { | ||
| return source.replace(/ /g, "\\ "); |
There was a problem hiding this comment.
Windows needs quotes around paths with spaces
| targets: [ | ||
| { | ||
| target_name: "foo", | ||
| sources: ["<!echo bar baz"], |
There was a problem hiding this comment.
unclear that this will work on Windows, at least without quotes. we probably want to specify PowerShell explicitly on that platform, and code to that.
mani3xis
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #96 by adding transformation of "defines".
Merging this PR will:
binding.gypfile.gyp-to-cmake#9)