Repository navigation
Write down testing rules and prune the suite against them - #397
Merged
Merged
Conversation
Contributor
Adapt Kent C. Dodds' testing principles: lightest flavor that can falsify, one test per workflow, independent oracles, a high bar for Playwright, no test seams in production, and a pruning pass agents can run. Gather the scattered testing bullets under one section and sharpen the AGENTS.md pointer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…testing First pruning pass under the new testing rules. Lunora tests are untouched (ADR 0061). No production code changed. - Independent oracles: expected values derived from exported constants (RESTORE_WINDOW_MS, FREE_NODE_LIMIT, MAX_FRAME_OPS, RESTORE_SLICE_OPS, DEMO_SEED_*, DAILY_CONTAINER_TEXT, CORE_FILTER_OPERATORS, ...) became hand-derived literals. - One behavior, one home: removed re-export copies (scaffold sortedInsertAfterId, daily-index localDateKey, runPromise), sibling-chain ordering outside its owner, searchNodes outside search.test.ts, and the MCP tool-name list copies in mcp.test.ts and cli commands.test.ts. - Unpinned copy and error wording; fixed two absence assertions that could not fail (opml-export view state, saved-queries blank row). - Collapsed single-assertion tests into workflow tests and test.each tables. - playwright.config.ts ignores the two *-real specs, which run under their own configs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cameronapak
force-pushed
the
claude/test-improvement-assessment-9e2e8a
branch
from
October 8, 2026 20:46
447d126 to
d182547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing guidance now favors the lightest check that can falsify behavior, and the suite removes duplicate or implementation-derived assertions without changing production code. Review context: Amp thread.
Changes
Start here: change 3 — consolidation must preserve distinct setup and projection paths.
Test plan
bun run test: 1,132 pass, 0 failbun run test:e2e:real: 47 pass, 0 failbun run test:e2e:app e2e/lunora-retirement-browser.spec.ts: 1 pass, 0 failtypecheck:test,lint, formatting, docs, and changeset checks: pass