Feature tarea buenas practicas #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2023 23:27
|
|
||
| class CodeBreaker: | ||
|
|
||
| def adivinar(self, numero=None): |
Owner
There was a problem hiding this comment.
Combinas nombres de variables, funciones y constantes entre español e ingles, te recomiendo mantener constancia con un solo idioma.
Owner
There was a problem hiding this comment.
Tambien te recomiendo darle un nombre mas descriptivo a esta función.
| return "Error: number must have 4 digits" | ||
|
|
||
| if numero == TRUE_NUMBER: | ||
| return True |
Owner
There was a problem hiding this comment.
Te recomiendo mantener constancia en el tipo de valor que vas a retornar, ya que en este momento estás combinando entre strings y booleans
| else: | ||
| caracter += ' ' | ||
|
|
||
| return caracter |
Owner
There was a problem hiding this comment.
Podrias modificar la logica para que agrupe primero las (X), luego los (_) bajos y por ultimo los espacios?
| return True | ||
|
|
||
| caracter = '' | ||
| array_number = [1] |
Owner
There was a problem hiding this comment.
Puedes agregar un comentario a esta variable explicando que hace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El siguiente código ya cuenta con el formato aplicado y linter.
Se relizan las adecuaciones para escribir código respetando el Zen de Python.