Skip to content

Add configurable metric evaluator to Engine#9

Merged
muhrin merged 1 commit into
camml-lab:developfrom
giotre:develop
Jun 18, 2026
Merged

Add configurable metric evaluator to Engine#9
muhrin merged 1 commit into
camml-lab:developfrom
giotre:develop

Conversation

@giotre

@giotre giotre commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Modified files:

  • src/reax/training/trainer.py

    • Forward metric_evaluator from Trainer to Engine.
    • Update the public metric_evaluator property to return the evaluator owned by Engine.
    • Update eval_stats so it uses the configured engine evaluator by default, while still allowing an explicit per-call override.
  • src/reax/_engine.py

    • Add optional metric_evaluator argument to Engine.
    • Store the configured evaluator on the engine.
    • Fall back to DefaultEvaluator when no evaluator is provided.
    • Expose the evaluator through a public metric_evaluator property.

@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/reax/training/trainer.py 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Files with missing lines Coverage Δ
src/reax/_engine.py 85.63% <100.00%> (ø)
src/reax/training/trainer.py 89.73% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@muhrin muhrin merged commit 3f7d628 into camml-lab:develop Jun 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants