Skip to content

Fix GCNN graph reductions for IrrepsArray inputs#12

Merged
muhrin merged 1 commit into
camml-lab:developfrom
giotre:develop
Jun 16, 2026
Merged

Fix GCNN graph reductions for IrrepsArray inputs#12
muhrin merged 1 commit into
camml-lab:developfrom
giotre:develop

Conversation

@giotre

@giotre giotre commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Modified files:

  • src/tensorial/gcnn/graph_ops.py

    • Fix graph segment reductions with e3nn_jax.IrrepsArray inputs.
    • Use functools.singledispatch to handle IrrepsArray inputs separately.
    • For IrrepsArray reductions, unwrap .array, apply the standard array reduction, and rewrap the result while preserving the original irreps.
    • Update _jraph_segment to use jax.tree.map.
  • tests/unit/gcnn/test_graph_ops.py

    • Add regression tests for IrrepsArray inputs in segment_sum, segment_mean, segment_min, segment_max, and graph_segment_reduce with node masks.

@codecov-commenter

codecov-commenter commented Jun 15, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/tensorial/gcnn/graph_ops.py 90.26% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@muhrin muhrin merged commit 77aad72 into camml-lab:develop Jun 16, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants