Skip to content

Conversation

@caniko
Copy link
Owner

@caniko caniko commented Dec 23, 2024

Type safe types are no longer called strict, but type_safe; typing namespace free of type files, but submodules, and the type files are now in the loading submodule.

@futurwasfree I couldn't add NpNDArray, how did you exclude it from the strict gen? We need to remove this part of the logic

@futurewasfree
Copy link
Contributor

@caniko
Toggle check here:

def _list_all_types(dimensions: int, strict: bool) -> list[str]:
    return [
        _type_name_with_prefix(dimensions, type_name, strict)
        for type_name in _DATA_TYPES
        if not (type_name == "" and not strict)
    ]

(see type_name == "" and not strict part, used to be and strict before)

@futurewasfree
Copy link
Contributor

also this might break some user code due to typename (and namespace) changes, e.g. if you import from strict folder.
deserves major version bump? or maybe you could maintain previous naming convention with "Strict" ?

@caniko
Copy link
Owner Author

caniko commented Dec 23, 2024

I hadn't bumped the version yet, and it is a breaking change

@caniko caniko force-pushed the refactor branch 3 times, most recently from 00f8e57 to 2aacda1 Compare December 24, 2024 15:31
Type safe types are no longer called strict, but type_safe; typing namespace free of type files, but submodules, and the type files are now in the loading submodule.
@caniko caniko merged commit 76aef06 into trunk Dec 24, 2024
21 checks passed
@caniko caniko deleted the refactor branch December 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants