Better error message when failing to connect to provider #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to log in as a user which doesn't have a local password yet
and the broker fails to connect to the provider, we showed this error:
could not get authentication modes: no authentication modes available for user "[email protected]"
That's not very helpful. This commit strips the "could not get
authentication modes:" part.
UDENG-8817
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
- Coverage 87.54% 87.53% -0.02%
==========================================
Files 91 91
Lines 6231 6231
Branches 111 111
==========================================
- Hits 5455 5454 -1
+ Misses 720 717 -3
- Partials 56 60 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return pamError{ | ||
| status: pam.ErrSystem, | ||
| msg: fmt.Sprintf("could not get authentication modes: %v", err), | ||
| msg: err.Error(), |
Member
There was a problem hiding this comment.
Pretty much the same concern I listed on the PR in the brokers repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to log in as a user which doesn't have a local password yet and the broker fails to connect to the provider, we showed this error:
That's not very helpful. This commit strips the "could not get authentication modes:" part.
UDENG-8817