Update launchpad api & oauth usage#554
Open
RuinedYourLife wants to merge 7 commits into
Open
Conversation
odadacharles
left a comment
odadacharles
left a comment
Collaborator
There was a problem hiding this comment.
I've left a few comments and suggestions. Please ask for a second review as well, perhaps from someone likely to have tried setting this up before.
Co-authored-by: odadacharles <charles.odada@canonical.com>
Co-authored-by: odadacharles <charles.odada@canonical.com>
Co-authored-by: odadacharles <charles.odada@canonical.com>
Maybe778
approved these changes
Jul 16, 2026
Updated section headings for consistency and clarity. Revised text for better understanding of the OAuth token exchange process.
Maybe778
approved these changes
Jul 16, 2026
Good |
Maybe778
approved these changes
Jul 16, 2026
ilkeremrekoc
left a comment
ilkeremrekoc
left a comment
Contributor
There was a problem hiding this comment.
I tested the instructions, and it worked out, I think it can be approved ^^. There are some problems and questions unrelated to the technical side however, can you take a look and if needed fix them?
| Projects <projects/index> | ||
| Packaging <packaging/index> | ||
| Launchpad web services API <launchpad-api/index> | ||
| Sign web requests <launchpad-web-signing> |
Contributor
There was a problem hiding this comment.
Why is this launchpad-web-signing while others use the sign-web-requests link name?
| Sign web requests | ||
| ================= | ||
|
|
||
| .. include:: /includes/important_not_revised_help.rst |
Contributor
There was a problem hiding this comment.
Shouldn't we remove this now?
|
|
||
| The request token lets Launchpad track your program between steps. To obtain | ||
| one, send a form-URL-encoded POST request to | ||
| ``<https://launchpad.net/+request-token>``_ (*not* ``api.launchpad.net``) with: |
Contributor
There was a problem hiding this comment.
This part is broken in the page
| signals they're done), exchange the temporary token for permanent credentials. | ||
|
|
||
| Send a form-encoded POST request to ``<https://launchpad.net/+access-token>``_ | ||
| (again, *not* ``api.launchpad.net``) with: |
Contributor
There was a problem hiding this comment.
This part is broken too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make linkcheck-discretelocally to confirm new or edited linkswill pass the linkcheck CI.