feat(cluster-link) add cluster link crud#1563
Draft
edlerd wants to merge 1 commit intocanonical:mainfrom
Draft
Conversation
Demo
Jenkins 
demos.haus 
edlerd
force-pushed
the
cluster-link-spike
branch
from
50712c4 to
b9845a7
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
from
b9845a7 to
48bc3db
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
from
48bc3db to
63826b0
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
3 times, most recently
from
f9bdb33 to
2758626
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
4 times, most recently
from
edb906a to
e843425
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
5 times, most recently
from
bbeb79e to
aa55af5
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
3 times, most recently
from
39994ff to
39c88bd
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
3 times, most recently
from
14e219d to
34c2f9a
Compare
edlerd
force-pushed
the
cluster-link-spike
branch
from
34c2f9a to
1acd87c
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
cluster-link-spike
branch
from
1acd87c to
ef9c5c2
Compare
kimanhou
reviewed
Apr 3, 2026
| import { ROOT_PATH } from "util/rootPath"; | ||
| import { addEntitlements } from "util/entitlements/api"; | ||
|
|
||
| const clusterLinkEntitlements = ["can_edit", "can_delete"]; |
Contributor
There was a problem hiding this comment.
Suggested change
| const clusterLinkEntitlements = ["can_edit", "can_delete"]; | |
| const CLUSTER_LINK_ENTITLEMENTS = ["can_edit", "can_delete"]; |
If this constant is just for this file, then the cluster link prefix might not be needed but I don't have a strong opinion on this. However, let's use all capital for constants.
| title={disableReason} | ||
| disabled={disableReason !== undefined} | ||
| > | ||
| <Icon name="plus" light /> |
Contributor
There was a problem hiding this comment.
Sometimes we the + icon with light, sometimes without. Any reason for that ?
Comment on lines
+19
to
+20
| appearance={"base"} | ||
| className={"u-no-margin--bottom"} |
Contributor
There was a problem hiding this comment.
Suggested change
| appearance={"base"} | |
| className={"u-no-margin--bottom"} | |
| appearance="base" | |
| className="u-no-margin--bottom" |
No need for curl brackets around constants
| ); | ||
| }) | ||
| .catch((e) => { | ||
| setLoading(false); |
Contributor
There was a problem hiding this comment.
I know that most our components are built this way, but should setLoading(false); be in finally ?
|
|
||
| const EditClusterLinkBtn: FC<Props> = ({ clusterLink }) => { | ||
| const { canEditClusterLink } = useClusterLinkEntitlements(); | ||
| const panel = usePanelParams(); |
Contributor
There was a problem hiding this comment.
Suggested change
| const panel = usePanelParams(); | |
| const panelParams = usePanelParams(); |
In the rest of the codebase, we call it panelParams
| const [howToUseActiveTab, setHowToUseActiveTab] = useState("ui-tab"); | ||
|
|
||
| return ( | ||
| <Modal |
Contributor
There was a problem hiding this comment.
Do you want to match exactly the beautiful CreateIdentityModal ? If so, here are the differences:
- tooltipMessage="Copy token"
- name of the cluster link in the title
- onClose not called in Modal's
close(but I'm not sure what are the consequences)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Still draft as the backend api is pending from canonical/lxd#17554