-
Notifications
You must be signed in to change notification settings - Fork 53
feat(CreateIdentityModal): improve identity creation flow #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CreateIdentityModal): improve identity creation flow #1697
Conversation
edlerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good ideas on expanding the steps to give the user direction on how to use the token. Some thoughts on streamlining the contents a bit below.
b471df9 to
87a1ac8
Compare
87a1ac8 to
65a80ea
Compare
edlerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts on the ui steps. Wdyt?
e079e2f to
4bab16f
Compare
edlerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more thoughts on the presentation copy and structure after a thorough review.
e23ddc8 to
5394251
Compare
edlerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nearly perfect. Two small observations below.
dc41b28 to
eb24870
Compare
edlerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just tiny ideas.
Signed-off-by: Kim Anh Nguyen <[email protected]>
eb24870 to
5d61d85
Compare
edlerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks for improvements :)
Done
QA
Screenshots
Before

After
