Skip to content

Conversation

@kimanhou
Copy link
Contributor

@kimanhou kimanhou commented Jan 6, 2026

Done

  • improve CreateIdentityModal

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Go to Permissions > Identities
    • Click on "Create TLS Identity" (top right corner of the page)
    • Input a name, like "foo"
    • Press Enter, or click on "Create identity" (bottom right corner of the page)
    • Make sure the modal gives clear guidance in what the token is and how it is to be used
    • Make sure you can't close the modal unless the checkbox is ticked
    • Make sure the "Done" button is enabled after you tick the "I have copied the token" checkbox
    • Make sure the "Done" button is enabled after you click on the "Copy token" button
    • Make sure the CLI and UI tabs are correctly displayed and that you can switch from one to the other

Screenshots

Before
before

After
Screenshot from 2026-01-09 15-00-41

@webteam-app
Copy link

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ideas on expanding the steps to give the user direction on how to use the token. Some thoughts on streamlining the contents a bit below.

@kimanhou kimanhou force-pushed the WD-31254-identity-creation-flow branch 5 times, most recently from b471df9 to 87a1ac8 Compare January 7, 2026 16:24
@kimanhou kimanhou force-pushed the WD-31254-identity-creation-flow branch from 87a1ac8 to 65a80ea Compare January 7, 2026 17:06
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on the ui steps. Wdyt?

@kimanhou kimanhou force-pushed the WD-31254-identity-creation-flow branch 2 times, most recently from e079e2f to 4bab16f Compare January 8, 2026 07:36
@kimanhou kimanhou self-assigned this Jan 8, 2026
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more thoughts on the presentation copy and structure after a thorough review.

@kimanhou kimanhou force-pushed the WD-31254-identity-creation-flow branch 2 times, most recently from e23ddc8 to 5394251 Compare January 8, 2026 15:48
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nearly perfect. Two small observations below.

@kimanhou kimanhou force-pushed the WD-31254-identity-creation-flow branch 2 times, most recently from dc41b28 to eb24870 Compare January 9, 2026 10:43
edlerd
edlerd previously approved these changes Jan 9, 2026
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just tiny ideas.

@kimanhou kimanhou force-pushed the WD-31254-identity-creation-flow branch from eb24870 to 5d61d85 Compare January 9, 2026 14:01
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for improvements :)

@kimanhou kimanhou merged commit 841b319 into canonical:main Jan 9, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants