Skip to content

Conversation

@Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Jan 8, 2026

Done

  • Anonymises hostnames in stack traces using regex.

Outstanding questions:

  • The regex targets urls that begin with 'https://' and have '/ui/' after the host portion. Does the https syntax have any limitations, or is it always expected LXD will run on a https web?
  • I must generate a real error to test the stack trace.

Related to: #1670

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Create an error in the UI (Or not) and select "Report a bug" in the navigation bar.
    • Ensure in the generated Github issue, that the hostname has been replaced with the <ANONYMOUS_HOST> placeholder.

Screenshots

Example:
image

@webteam-app
Copy link

Copy link
Contributor

@omarelkashef omarelkashef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! One small comment below

@Kxiru Kxiru force-pushed the anonymise-stack-trace branch from edda978 to f65a5ca Compare January 8, 2026 16:04
omarelkashef
omarelkashef previously approved these changes Jan 8, 2026
Copy link
Contributor

@omarelkashef omarelkashef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thank you!

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small adjustment below

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Kxiru Kxiru merged commit 6f7edbc into canonical:main Jan 8, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants