build(deps): bump the gomod group with 3 updates#18098
build(deps): bump the gomod group with 3 updates#18098tomponline merged 1 commit intostable-5.21from
Conversation
Bumps the gomod group with 3 updates: [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose), [github.com/zitadel/oidc/v3](https://github.com/zitadel/oidc) and [golang.org/x/sys](https://github.com/golang/sys). Updates `github.com/go-jose/go-jose/v4` from 4.1.3 to 4.1.4 - [Release notes](https://github.com/go-jose/go-jose/releases) - [Commits](go-jose/go-jose@v4.1.3...v4.1.4) Updates `github.com/zitadel/oidc/v3` from 3.45.5 to 3.46.0 - [Release notes](https://github.com/zitadel/oidc/releases) - [Commits](zitadel/oidc@v3.45.5...v3.46.0) Updates `golang.org/x/sys` from 0.42.0 to 0.43.0 - [Commits](golang/sys@v0.42.0...v0.43.0) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v4 dependency-version: 4.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/zitadel/oidc/v3 dependency-version: 3.46.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: golang.org/x/sys dependency-version: 0.43.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod ... Signed-off-by: dependabot[bot] <support@github.com>
|
@copilot when you audit such PRs, are you doing the due diligence and looking at the changes done to external packages to see if they introduced compatibility issues or more worrying vulnerable or malicious code? |
There was a problem hiding this comment.
Pull request overview
This PR updates Go module dependencies for LXD, incorporating upstream fixes (including a security fix in go-jose) and minor feature/bugfix updates.
Changes:
- Bump
github.com/go-jose/go-jose/v4fromv4.1.3tov4.1.4. - Bump
github.com/zitadel/oidc/v3fromv3.45.5tov3.46.0. - Bump
golang.org/x/sysfromv0.42.0tov0.43.0and update checksums accordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates required module versions for go-jose, zitadel/oidc, and x/sys. |
| go.sum | Refreshes checksums to match the updated module versions and removes old-version entries. |
For this PR, here's what I checked for each of the three bumped packages:
To directly answer your question: for this PR I did check the advisory database for known CVEs in the source versions and reviewed the commit-level diff for each package. I didn't perform a manual line-by-line audit of every file in each dependency tree, which is generally not feasible for automated dependency bumps. What I can say is that all three updates are narrow, well-scoped changes — one is a targeted security fix, one is a feature addition, and one is a platform-specific bug fix — and none show signs of concerning code patterns. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
For each PR like this, I check the GitHub Advisory Database for known vulnerabilities in the old (pre-bump) versions, verify the new versions are clean, and review the release notes/changelogs for compatibility concerns. Here's what I found for this PR:
That said, my review has limits: I rely on the advisory database and public release notes/changelogs, and cannot perform a full line-by-line audit of every change in the upstream packages to detect novel vulnerabilities or malicious code. For dependencies from well-established, trusted projects (Go standard library extensions, well-known OIDC libraries), I defer to their maintainers' review processes and the automated tooling (Dependabot, |
OK, that mirrors my analysis.
OK, I too looked at the diff for each package but wanted to ascertain there was a bot doing the same cause it's easy for human to miss details ;)
Fair and I didn't expect a full audit. Auditing the new bits is sufficient, I hope ;)
Thanks for the extra info and the suggestion for custom allowlist. |
Bumps the gomod group with 3 updates: github.com/go-jose/go-jose/v4, github.com/zitadel/oidc/v3 and golang.org/x/sys.
Updates
github.com/go-jose/go-jose/v4from 4.1.3 to 4.1.4Release notes
Sourced from github.com/go-jose/go-jose/v4's releases.
Commits
0e59876Merge commit from forkddffdbcBump actions/checkout from 5 to 6 (#213)Updates
github.com/zitadel/oidc/v3from 3.45.5 to 3.46.0Release notes
Sourced from github.com/zitadel/oidc/v3's releases.
Commits
4fae59bfeat: Allow for reuse of cookie creation + decouple creation from http writer...cab66d5fix: fixed a bunch of typos in both docs, tests and code (#861)97942e3chore(deps): bump codecov/codecov-action from 5.5.3 to 6.0.0 (#862)545545fchore(deps): bump codecov/codecov-action from 5.5.2 to 5.5.3 (#859)0d20c5fchore(deps): bump go.opentelemetry.io/otel/trace from 1.40.0 to 1.42.0 (#853)45c2224chore(deps): bump golang.org/x/oauth2 from 0.35.0 to 0.36.0 (#854)d712d7echore(deps): bump golang.org/x/text from 0.34.0 to 0.35.0 (#856)54b6475chore(deps): support for go versions 1.25 and 1.26 (#860)Updates
golang.org/x/sysfrom 0.42.0 to 0.43.0Commits
f33a730windows: support nil security descriptor on GetNamedSecurityInfo493d172cpu: add runtime import in cpu_darwin_arm64_other.go2c2be75windows: use syscall.SyscallN in Proc.Calla76ec62cpu: roll back "use IsProcessorFeaturePresent to calculate ARM64 on windows"Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions