Skip to content

Conversation

@gatici
Copy link
Contributor

@gatici gatici commented Jan 5, 2026

Description of issue or feature:

This PR fixes Terraform evaluation errors in the large deployment configuration when the failover orchestrator is optional.

When failover is not provided, Terraform was attempting to dereference var.failover.model_uuid and access outputs from modules created with for_each, causing failures during terraform module validation.

Solution

  • Guarded access to var.failover.model_uuid in locals 1
  • Fixed output handling by using try(..., null) to avoid failures when failover is not deployed 2 3

How was this change tested?

  • Manually
  • Unit tests
  • Integration tests

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

akram09
akram09 previously approved these changes Jan 5, 2026
Copy link
Contributor

@akram09 akram09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gatici

@akram09
Copy link
Contributor

akram09 commented Jan 5, 2026

Small comment.
I was thinking that we should fix the terraform provider version so that it don't take other versions and make the pipeline fails again

akram09
akram09 previously approved these changes Jan 5, 2026
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gulsum! just a minor comment on the TF version

@gatici gatici requested a review from skourta January 9, 2026 09:53
@gatici gatici merged commit 00661aa into 2/edge Jan 9, 2026
236 of 248 checks passed
@gatici gatici deleted the fix-terraform-validation branch January 9, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants