[DPE-8318] Predefined roles docs #1107
Conversation
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
added
the
not bug or enhancement
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
LGTM, can you please add description about the proper way of escalating the privileges?
| test123=> SELECT * FROM pg_roles WHERE rolname LIKE 'charmed_test_%'; | ||
| rolname | rolsuper | rolinherit | rolcreaterole | rolcreatedb | rolcanlogin | rolreplication | rolconnlimit | rolpassword | rolvaliduntil | rolbypassrls | rolconfig | oid | ||
| --------------------+----------+------------+---------------+-------------+-------------+----------------+--------------+-------------+---------------+--------------+-----------+------- | ||
| charmed_test_owner | f | t | f | f | f | f | -1 | ******** | | f | | 16396 |
There was a problem hiding this comment.
What happens when I request database databases, re: charmed_databases_owner in line 61?
There was a problem hiding this comment.
The charm will throw an error. I'm currently working on fixing that. Thanks for catching this.
There was a problem hiding this comment.
Fixed on canonical/postgresql-single-kernel-library#18 (there are two follow-up PRs in the operators repositories).
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
a-velasco
left a comment
a-velasco
left a comment
There was a problem hiding this comment.
Thank you @marceloneppel!
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Apologies, Alex! I missed your request about escalation. I updated the PR on e2a92e4 with that. Could you review it again, @taurus-forever and @a-velasco? Thanks! |
docs/explanation/roles.md
Outdated
| Regular relation users can temporarily escalate their privileges to other predefined roles using PostgreSQL's role-switching features. There are two approaches: | ||
|
|
||
| - SET ROLE / RESET ROLE (standard, built-in) | ||
| - The `set_user` |
There was a problem hiding this comment.
Maybe The set_user/reset_user` to mimic line above.
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
|
@marceloneppel feel free to merge this on Friday if Mohamed has no chance to review it. |
Issue
There is no documentation for the new predefined roles.
Solution
Document those roles, as it was done for the PG 16 VM charm (canonical/postgresql-operator#1054).
Update the users' documentation to reflect the new roles structure (removing the
adminextra user role, which exists only for the PG 14 charm).Also, fix the
toctreefromdocs/explanation/index.mdbased on the approach suggested on https://github.com/canonical/postgresql-operator/pull/1084/files/3359f0ab7338cee122a4e3215ec4f1ac350a9b4a#r2259899679 and fix some Juju anchors.Checklist