-
Notifications
You must be signed in to change notification settings - Fork 27
Refresh v3 implementation #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marceloneppel
wants to merge
25
commits into
16/edge
Choose a base branch
from
refresh-v3
base: 16/edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
dcdc4dd
Add first part of refresh v3 implementation
marceloneppel 02651eb
Add second part of refresh v3 implementation
marceloneppel cd935f2
Merge remote-tracking branch 'origin/16/edge' into refresh-v3
marceloneppel 0e073d0
Update poetry.lock
marceloneppel 086bc7c
Revert (for testing) Set charm refresh compatibility version from git…
marceloneppel 13fe1c2
Merge remote-tracking branch 'origin/16/edge' into refresh-v3
marceloneppel 6482969
Update logic refresh to start workload at the right time
marceloneppel c40d26e
Wait some seconds before calling resume-refresh
marceloneppel 7fe482a
Fix both integration tests and make them handle incompatible upgrades
marceloneppel e53aa35
Fix unit tests
marceloneppel 9b9b03a
Remove partition check
marceloneppel 2a806f7
Remove charm refresh compatibility versioning from the git tag implem…
marceloneppel 38e4870
Remove commented code, fix scale down and pre-refresh check, and add …
marceloneppel 9c1a026
Remove debug error messages
marceloneppel 18c51c4
Switchover to unit zero when needed on upgrade tests
marceloneppel 7a9c052
Fix trust test
marceloneppel bc4729f
Fix redis-k8s channel
marceloneppel d3a753e
Remove commented code
marceloneppel dfe5b0a
Remove commented code and fix log calls
marceloneppel 06c15fe
Fix redis-k8s base
marceloneppel c7cdacd
Increase tests timeouts
marceloneppel ed74668
Increase one more test timeout
marceloneppel 1cfc44d
Increase test timeout
marceloneppel 46eac97
Merge remote-tracking branch 'origin/16/edge' into refresh-v3
marceloneppel 86860f1
Reorder call to refresh logic and don't immediatelly exit hook when r…
marceloneppel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,19 +19,24 @@ jobs: | |
| uses: actions/checkout@v5 | ||
| - name: Set up environment | ||
| run: | | ||
| sudo snap install charmcraft --classic | ||
| sudo snap install go --classic | ||
| go install github.com/snapcore/spread/cmd/spread@latest | ||
| pipx install tox poetry | ||
| - name: Collect spread jobs | ||
| id: collect-jobs | ||
| shell: python | ||
| run: | | ||
| import json | ||
| import pathlib | ||
| import os | ||
| import subprocess | ||
|
|
||
| spread_jobs = ( | ||
| subprocess.run( | ||
| ["charmcraft", "test", "--list", "github-ci"], capture_output=True, check=True, text=True | ||
| [pathlib.Path.home() / "go/bin/spread", "-list", "github-ci"], | ||
| capture_output=True, | ||
| check=True, | ||
| text=True, | ||
|
Comment on lines
+36
to
+39
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update to list tests now that we're using charmcraft v4. |
||
| ) | ||
| .stdout.strip() | ||
| .split("\n") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| # Copyright 2023 Canonical Ltd. | ||
| # See LICENSE file for licensing details. | ||
| name: Release to Charmhub | ||
| name: Release to Charmhub edge | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - '16/edge' | ||
| - '*/edge' | ||
| paths-ignore: | ||
| - 'tests/**' | ||
| - 'docs/**' | ||
|
|
@@ -16,37 +16,21 @@ on: | |
| - '.github/workflows/sync_docs.yaml' | ||
|
|
||
| jobs: | ||
|
|
||
| ci-tests: | ||
| name: Tests | ||
| uses: ./.github/workflows/ci.yaml | ||
| secrets: inherit | ||
| permissions: | ||
| contents: write # Needed for Allure Report | ||
|
|
||
| release-libraries: | ||
| name: Release libraries | ||
| needs: | ||
| - ci-tests | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Release charm libraries | ||
| uses: canonical/charming-actions/[email protected] | ||
| with: | ||
| credentials: "${{ secrets.CHARMHUB_TOKEN }}" | ||
| github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
|
||
| release: | ||
| name: Release charm | ||
| needs: | ||
| - ci-tests | ||
| uses: canonical/data-platform-workflows/.github/workflows/[email protected] | ||
| with: | ||
| track: 16 | ||
| track: '16' | ||
| artifact-prefix: ${{ needs.ci-tests.outputs.artifact-prefix }} | ||
| secrets: | ||
| charmhub-token: ${{ secrets.CHARMHUB_TOKEN }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,6 +86,7 @@ parts: | |
| source: . | ||
| stage: | ||
| - LICENSE | ||
| - refresh_versions.toml | ||
| - scripts | ||
| - templates | ||
| libpq: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to match the rule we have in the VM charm.