fix: recreate headless service if deleted externally#1349
Draft
marceloneppel wants to merge 2 commits into16/edgefrom
Draft
fix: recreate headless service if deleted externally#1349marceloneppel wants to merge 2 commits into16/edgefrom
marceloneppel wants to merge 2 commits into16/edgefrom
Conversation
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
github-actions
bot
added
the
Libraries: Out of sync
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (68.46%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1349 +/- ##
===========================================
- Coverage 68.64% 68.46% -0.18%
===========================================
Files 16 16
Lines 3881 3904 +23
Branches 590 592 +2
===========================================
+ Hits 2664 2673 +9
- Misses 1009 1022 +13
- Partials 208 209 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add integration test verifying charm recreates the headless endpoints service after deletion. Includes spread task configuration for CI. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Port of #1348.
Checklist