refactor: BaseCloud method returns config instead of setting config #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames the _check_and_set_config method of the BaseCloud class to _check_and_get_config, and modifies the method such that it returns a dict instead of setting the config instance variable. This change facilitates modification of the method's behaviour during unit testing.
danpdraper
force-pushed
the
return-config-instead-of-setting-config
branch
from
552acb0 to
db572fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the
_check_and_set_configmethod of the BaseCloud class to_check_and_get_config, and modifies the method such that it returns a dict instead of setting the config instance variable. This change facilitates modification of the method's behaviour during unit testing.