Skip to content

fix: avoid trapping tab key presses when the search and filter is closed #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edlerd merged 1 commit into from
Dec 12, 2024
Merged

fix: avoid trapping tab key presses when the search and filter is closed #1163

edlerd merged 1 commit into from
Dec 12, 2024

Conversation

@edlerd
Copy link
Contributor

@edlerd edlerd commented Dec 12, 2024

Done

  • avoid trapping tab key presses when the search and filter is closed

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA steps

  • open the search and filter in storybook
  • press tab and ensure you can tab over the closed search and filter with few tab key presses
  • previously, all the hidden chips in the hidden search and filter panel would trap the tab key.

@edlerd
fix(search) avoid trapping tab key presses when the search and filter…
9e96e03 
… is closed n the hidden chips

Signed-off-by: David Edler <[email protected]>
@webteam-app
Copy link

webteam-app commented Dec 12, 2024

Demo

Jenkins

demos.haus

@edlerd edlerd changed the title avoid trapping tab key presses when the search and filter is closed Fix: avoid trapping tab key presses when the search and filter is closed Dec 12, 2024
@edlerd edlerd changed the title Fix: avoid trapping tab key presses when the search and filter is closed fix: avoid trapping tab key presses when the search and filter is closed Dec 12, 2024
fasih-mehmood
fasih-mehmood approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@fasih-mehmood fasih-mehmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@edlerd edlerd merged commit 86e2b2a into main Dec 12, 2024
10 of 11 checks passed
@github-actions
Copy link

github-actions bot commented Dec 12, 2024

🎉 This PR is included in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fasih-mehmood fasih-mehmood deleted the avoid-key-trap-search-filter branch June 30, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fasih-mehmood fasih-mehmood fasih-mehmood approved these changes

Assignees

No one assigned

Labels

released Review: Code +1 Review: Percy needed Review: QA +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edlerd @webteam-app @fasih-mehmood