Reboot control host before provisioning#837
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 70.10% 71.93% +1.82%
==========================================
Files 108 108
Lines 9477 9859 +382
Branches 843 866 +23
==========================================
+ Hits 6644 7092 +448
+ Misses 2673 2590 -83
- Partials 160 177 +17
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
amalinowski75
left a comment
There was a problem hiding this comment.
Make sense. Just a few minor comments.
device-connectors/src/testflinger_device_connectors/devices/__init__.py
Outdated
Show resolved
Hide resolved
device-connectors/src/testflinger_device_connectors/devices/__init__.py
Outdated
Show resolved
Hide resolved
device-connectors/src/testflinger_device_connectors/devices/__init__.py
Outdated
Show resolved
Hide resolved
nancyc12
reviewed
Nov 28, 2025
device-connectors/src/testflinger_device_connectors/devices/__init__.py
Outdated
Show resolved
Hide resolved
0c71ba8 to
3a24a13
Compare
Contributor
Author
|
Please check again the PR description: I added an additional check in a couple of connectors to wait for RPyC to be available. |
amalinowski75
approved these changes
Jan 19, 2026
amalinowski75
left a comment
There was a problem hiding this comment.
Thanks for the changes, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR propose a programmatic way to reboot the control host just before provisioning in case it's not reachable.
This is still opt-in (you need to call the super() method), but I think it's safe to call it everywhere for now, since it doesn't raise any error. We could also wrap it in
try/except Exceptionif it makes sense.Also, connectors relying on a specific control host, now also wait for the service of interest to be available.
Resolved issues
N/A
Documentation
N/A
Web service API changes
No!
Tests
Test with functional control host machine:
Test with not reachable control host (Cannot run snmp commands remotely, from source) :
^ as you can see here, we attempted reboot but failed. Provisioning will continue, because the specific device connector is responsible for checking what it actually needs.