capnp-rpc: Add disconnect_background to Disconnector #581
+17
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a public
disconnect_background
function toDisconnector
so that you can signal it to disconnect but not have to wait for it to do so.I usually run the
RpcSystem
withspawn_local
and would like to be able to just signal that it should shut down in like aDrop
implementation for my Client.It would also make my graceful shutdown listener for the server slightly less clunky since that needs to do this:
While with this PR it would look like this: