Skip to content

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Oct 11, 2025

We've observed unexpected reallocations on some flamegraphs here.

image

Looks like it stems from 5afd805. cc @dwrensha

We've observed unexpected reallocations on some flamegraphs here.
@bobrik
Copy link
Contributor Author

bobrik commented Oct 11, 2025

Perhaps the right thing to do is to put / BYTES_PER_WORD into compute_serialized_size_in_words where it would match the label and leave compute_serialized_size and flatten_segments without it. Let me know what you think.

Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.65%. Comparing base (ab342b3) to head (1a2c816).
⚠️ Report is 198 commits behind head on master.

Files with missing lines Patch % Lines
capnp/src/serialize.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   51.64%   50.65%   -0.99%     
==========================================
  Files          69       70       +1     
  Lines       33735    32331    -1404     
==========================================
- Hits        17422    16377    -1045     
+ Misses      16313    15954     -359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dwrensha dwrensha merged commit 14b38d3 into capnproto:master Oct 11, 2025
10 checks passed
@dwrensha
Copy link
Member

Good catch! Thanks! I'll touch this up a bit...

@dwrensha
Copy link
Member

I implemented your suggestion in 41f933c.

@bobrik bobrik deleted the ivan/exact-capacity branch October 15, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants