feat: toggle phone number registration #1157
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closes #1156 |
ashutosh1206
force-pushed
the
feat/toggle-phone
branch
from
86f929c to
cbb19fe
Compare
ashutosh1206
suggested changes
Sep 1, 2022
| import { checkAccountStatus, getIsAccountIdOnboarded } from './near' | ||
| import { capsuleServer, sufficientFunds } from './utilities/config' | ||
|
|
||
| export async function requestOTP(phoneNumber: string) { |
Contributor
There was a problem hiding this comment.
You should also add a captchaRes to requestOTP() function. Basically, when phone number toggle is on, we want the user to solve captcha when request for an OTP from their phone number (ie. requestOTP() function)
Contributor
|
We also might have to disable/skip captcha verification on select-username step if phone number toggle is enabled, since captcha verification happens on enter-phone-number step in that case |
Contributor
Author
|
Pulled from backend channel:
|
chrispanag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.