Skip to content

chore: upgrade Storybook to 10.3.5#22116

Open
tay1orjones wants to merge 7 commits intocarbon-design-system:mainfrom
tay1orjones:task/storybook-v10.3.5
Open

chore: upgrade Storybook to 10.3.5#22116
tay1orjones wants to merge 7 commits intocarbon-design-system:mainfrom
tay1orjones:task/storybook-v10.3.5

Conversation

@tay1orjones
Copy link
Copy Markdown
Member

@tay1orjones tay1orjones commented Apr 24, 2026

Changelog

Changed

  • Updated Storybook packages to 10.3.5.
  • Converted the React Storybook config to main.ts
  • Updated the web-components Storybook config for Storybook 10 ESM loading.

Removed

  • Legacy CommonJS-style Storybook config in packages/react/.storybook/main.js.
  • A resolutions entry that is no longer necessary and was causing the build to fail
  • Invalid use of storybook actions within test files

Testing / Reviewing

  • Check both deploy previews to ensure all functions of storybook still work. Look through multiple stories, docs and canvas, check that addons work in the addons panel, header item dropdowns and buttons work.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
    - [ ] Wrote passing tests that cover this change
    - [ ] Addressed any impact on accessibility (a11y)
    - [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c4198cd
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69eba5269fb1000008f42b6b
😎 Deploy Preview https://deploy-preview-22116--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c4198cd
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69eba52672ad2b0008d37645
😎 Deploy Preview https://deploy-preview-22116--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit cae589c
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f5003736deaa000880dd1f
😎 Deploy Preview https://deploy-preview-22116--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit cae589c
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f50037b0c4b5000851ba66
😎 Deploy Preview https://deploy-preview-22116--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.09%. Comparing base (21677a1) to head (cae589c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22116      +/-   ##
==========================================
- Coverage   95.10%   95.09%   -0.01%     
==========================================
  Files         548      548              
  Lines       45559    45559              
  Branches     6519     6547      +28     
==========================================
- Hits        43327    43326       -1     
- Misses       2102     2103       +1     
  Partials      130      130              
Flag Coverage Δ
main-packages 89.15% <ø> (ø)
web-components 97.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tay1orjones tay1orjones marked this pull request as ready for review April 24, 2026 18:42
@tay1orjones tay1orjones requested a review from a team as a code owner April 24, 2026 18:42
@tay1orjones tay1orjones self-assigned this Apr 24, 2026
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Apr 24, 2026
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🚦 In Review in Design System Apr 24, 2026
Copy link
Copy Markdown
Contributor

@maradwan26 maradwan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tay1orjones
Copy link
Copy Markdown
Member Author

I duplicated the brace expansion fix over in #22061 because it needed it as well. I think that could land first but will resolve the conflict however it happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🚦 In Review

Development

Successfully merging this pull request may close these issues.

2 participants