feat: allow plex override#22119
feat: allow plex override#22119davidmenendez wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22119 +/- ##
==========================================
- Coverage 95.07% 95.05% -0.03%
==========================================
Files 539 539
Lines 45093 45093
Branches 6517 6551 +34
==========================================
- Hits 42874 42861 -13
- Misses 2091 2104 +13
Partials 128 128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Interesting - so you're thinking just overriding the font family, not actually loading in other assets. Would there need to be a change to the resolver? Or document what would be needed there for someone overriding this?
Would it make sense to be able to turn off the loading of plex if this was configured like this?
Closes #22118
updates
@carbon/typepackage to allow consumers to override the Plex font-family.Changelog
Changed
@carbon/typepackage to allow consumers to override the Plex font-family.Testing / Reviewing
yarn test && yarn test -uas well as manual testingPR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide