Skip to content

feat: allow plex override#22119

Open
davidmenendez wants to merge 1 commit intocarbon-design-system:mainfrom
davidmenendez:issue-22118
Open

feat: allow plex override#22119
davidmenendez wants to merge 1 commit intocarbon-design-system:mainfrom
davidmenendez:issue-22118

Conversation

@davidmenendez
Copy link
Copy Markdown
Contributor

Closes #22118

updates @carbon/type package to allow consumers to override the Plex font-family.

Changelog

Changed

  • updates @carbon/type package to allow consumers to override the Plex font-family.

Testing / Reviewing

yarn test && yarn test -u as well as manual testing

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@davidmenendez davidmenendez requested a review from a team as a code owner April 24, 2026 19:09
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df49b51
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69ebbfde77191700081e1a89
😎 Deploy Preview https://deploy-preview-22119--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit df49b51
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69ebbfde782afa000805256e
😎 Deploy Preview https://deploy-preview-22119--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.05%. Comparing base (03ffff1) to head (df49b51).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22119      +/-   ##
==========================================
- Coverage   95.07%   95.05%   -0.03%     
==========================================
  Files         539      539              
  Lines       45093    45093              
  Branches     6517     6551      +34     
==========================================
- Hits        42874    42861      -13     
- Misses       2091     2104      +13     
  Partials      128      128              
Flag Coverage Δ
main-packages 89.12% <ø> (ø)
web-components 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - so you're thinking just overriding the font family, not actually loading in other assets. Would there need to be a change to the resolver? Or document what would be needed there for someone overriding this?

### Custom font src resolver

Would it make sense to be able to turn off the loading of plex if this was configured like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow consumers to override Plex with custom fonts

2 participants