fix(a11y): default dangerDescription to empty string#22121
Open
tay1orjones wants to merge 9 commits intocarbon-design-system:mainfrom
Open
fix(a11y): default dangerDescription to empty string#22121tay1orjones wants to merge 9 commits intocarbon-design-system:mainfrom
dangerDescription to empty string#22121tay1orjones wants to merge 9 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22121 +/- ##
==========================================
+ Coverage 95.05% 95.06% +0.01%
==========================================
Files 539 541 +2
Lines 45156 45190 +34
Branches 6493 6553 +60
==========================================
+ Hits 42922 42962 +40
+ Misses 2105 2099 -6
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Wow that was fast. This looks great to me. |
tombrunet
reviewed
Apr 27, 2026
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
…sk/danger-description-empty-default
…y1orjones/carbon into task/danger-description-empty-default
wkeese
reviewed
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20515
Changelog
New
dangerDescriptionto components that utilize danger buttonsChanged
dangerDescriptionto an empty string in react and web componentsTesting / Reviewing
dangerDescriptionshould be configurable in the impacted storiesPR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Tested for cross-browser consistencyMore details can be found in the pull request guide