Skip to content

fix(file-uploader): align accept parsing with native file input#22134

Open
nehaaprasaad wants to merge 2 commits intocarbon-design-system:mainfrom
nehaaprasaad:fix/cds-fil-acce-par
Open

fix(file-uploader): align accept parsing with native file input#22134
nehaaprasaad wants to merge 2 commits intocarbon-design-system:mainfrom
nehaaprasaad:fix/cds-fil-acce-par

Conversation

@nehaaprasaad
Copy link
Copy Markdown

@nehaaprasaad nehaaprasaad commented Apr 28, 2026

Closes #22111

Fixes multi-value accept parsing in file uploader components.

Changelog

New
None.

Changed
Parse accept with spaces and commas.
Normalize native input accept to comma-separated tokens.
Removed

None.

Testing / Reviewing

Test accept="image/jpeg image/png".
Test accept="image/jpeg,image/png".
Confirm unsupported files are not added.
Confirm single-value and extension-only still work.

PR Checklist

  • As the author of this PR, before marking ready for review, confirm you:
    [ ] Reviewed every line of the diff
    [ ] Updated documentation and storybook examples
    [ ] Wrote passing tests that cover this change
    [ ] Addressed any impact on accessibility (a11y)
    [ ] Tested for cross-browser consistency
    [ ] Validated that this code is ready for review and status checks should pass

@nehaaprasaad nehaaprasaad requested a review from a team as a code owner April 28, 2026 12:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0673f51
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f4aacd3e00fc00084685d0
😎 Deploy Preview https://deploy-preview-22134--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0673f51
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f4aacd46d7ba0008bb12f7
😎 Deploy Preview https://deploy-preview-22134--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@tay1orjones
Copy link
Copy Markdown
Member

Please update to use the pull request template.

@kennylam
Copy link
Copy Markdown
Member

Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

You need to sign the DCO as well.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.07%. Comparing base (cdca471) to head (b4e93a9).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22134      +/-   ##
==========================================
- Coverage   95.09%   95.07%   -0.03%     
==========================================
  Files         541      541              
  Lines       45179    45179              
  Branches     6537     6482      -55     
==========================================
- Hits        42965    42954      -11     
- Misses       2085     2096      +11     
  Partials      129      129              
Flag Coverage Δ
main-packages 89.16% <ø> (ø)
web-components 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nehaaprasaad
Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: cds-file-uploader-*: accept is parsed two different ways internally, silently dropping multi-value selections

3 participants