Skip to content

Revert "fix(menu): nested menu closes unexpectedly when hovering back from submenu item to parent menu item"#22142

Open
maradwan26 wants to merge 2 commits intomainfrom
revert-20881-bugfix/Hover-issue-in-menu-button
Open

Revert "fix(menu): nested menu closes unexpectedly when hovering back from submenu item to parent menu item"#22142
maradwan26 wants to merge 2 commits intomainfrom
revert-20881-bugfix/Hover-issue-in-menu-button

Conversation

@maradwan26
Copy link
Copy Markdown
Contributor

@maradwan26 maradwan26 commented Apr 29, 2026

Reverts #20881
Closes #21380

Some more context:
#21380 (comment)
#21380 (comment)

@maradwan26 maradwan26 marked this pull request as ready for review April 29, 2026 16:43
@maradwan26 maradwan26 requested a review from a team as a code owner April 29, 2026 16:43
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 75dc9ac
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f3922064a3f500089e5508
😎 Deploy Preview https://deploy-preview-22142--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 75dc9ac
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f39220dcfe3f000899975f
😎 Deploy Preview https://deploy-preview-22142--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.08%. Comparing base (0ba3f47) to head (75dc9ac).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22142      +/-   ##
==========================================
- Coverage   95.08%   95.08%   -0.01%     
==========================================
  Files         541      546       +5     
  Lines       45217    45474     +257     
  Branches     6560     6540      -20     
==========================================
+ Hits        42996    43240     +244     
- Misses       2092     2105      +13     
  Partials      129      129              
Flag Coverage Δ
main-packages 89.13% <100.00%> (+<0.01%) ⬆️
web-components 97.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this to 🕵️‍♀️ Triage in Design System Apr 30, 2026
@maradwan26 maradwan26 self-assigned this Apr 30, 2026
@maradwan26 maradwan26 moved this from 🕵️‍♀️ Triage to 🚦 In Review in Design System Apr 30, 2026
Copy link
Copy Markdown
Contributor

@adamalston adamalston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a test be added to cover the issue? If not, what would prevent the same change from being made again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: MenuButton no longer closes when clicking outside the menu

3 participants